Issues

Add base class whitelist option

enhancement

#68

· steven-cutting opened

on Feb 11, 2026

Update the claude.md/agents.md files with information about these tests and when to run them.

#63

· steven-cutting opened

on Feb 11, 2026

Let's plan on adding an optional (manual trigger) GitHub action job for running these. Configured so that they run in parallel.

#62

· steven-cutting opened

on Feb 11, 2026

These smoke tests will fail with an unhandled exception in environments without `git` installed or without network access to GitHub. To keep the tests actionable for contributors, add a pre-check (e.g., `shutil.which("git")`) and skip with a clear reason when prerequisites aren’t met, and consider handling clone failures by skipping/xfailing rather than erroring.

#61

· steven-cutting opened

on Feb 11, 2026

`capture_output=True` collects stdout for every violation in these large repos, but the test never inspects stdout. Consider discarding stdout (e.g., redirect to DEVNULL) and only capturing stderr to reduce memory/IO overhead and avoid huge buffered output on larger repos.

#60

· steven-cutting opened

on Feb 11, 2026

Cloning the default branch of external repositories makes this test non-deterministic and likely to become flaky over time (upstream changes, force-pushes, or newer syntax than this project’s supported Python). Consider pinning each clone to a specific tag/commit (e.g., via `--branch`/`--tag` + shallow clone, or checkout a known SHA) so the smoke test remains stable and reproducible.

#59

· steven-cutting opened

on Feb 11, 2026

The Compatibility section claims support for Flake8 6.x and 7.x, but the repo appears to lock Flake8 to 7.3.0 (uv.lock) and CI doesn’t run a matrix over Flake8 versions. To avoid overstating support, consider changing this to "Flake8: >=6.0" (or "tested on 7.x") or add CI coverage for Flake8 6.x if you want to claim it explicitly.

#54

· steven-cutting opened

on Feb 11, 2026

Flake8 (as depended on by this project: `flake8>=6.0`) does not read configuration from `pyproject.toml` by default. The Quickstart should either omit the `pyproject.toml` example or explicitly note that users need an additional helper (e.g., a pyproject-compatible flake8 config loader) for `[tool.flake8]` to be honored.

#46

· steven-cutting opened

on Feb 11, 2026

`parse_options()` has explicit branches for when flake8 provides `comma_separated_list` values as `list[str]`, but the tests currently only cover the string/None paths. Add test cases passing `project_packages=[...]` and `inh002_allowed_dunders=[...]` to ensure the list-handling behavior stays correct.

#39

· steven-cutting opened

on Feb 10, 2026

`run()` now reparses imports and re-walks the AST once per configured `--project-packages` entry (each `ImportTracker.visit()` + `InheritanceVisitor.visit()`), which makes runtime scale linearly with the number of packages. Consider changing `ImportTracker` to accept a set of project packages and classify `internal` when `source_module in project_packages`, so the file is visited only once.

enhancement

#38

· steven-cutting opened

on Feb 10, 2026

`add_options` is annotated to take `OptionManager`, but the tests pass a spy object. With `mypy --strict` running on `tests/`, this will be flagged as an incompatible argument type. Consider typing `parser` as a small `Protocol` (e.g., something with `add_option(...)`) or `Any`/`object` + runtime duck-typing to keep both plugin correctness and test type-checking.

#37

· steven-cutting opened

on Feb 10, 2026

Navigation Menu

All issues

Add base class whitelist option

Update the claude.md/agents.md files with information about these tests and when to run them.

Let's plan on adding an optional (manual trigger) GitHub action job for running these. Configured so that they run in parallel.

`capture_output=True` collects stdout for every violation in these large repos, but the test never inspects stdout. Consider discarding stdout (e.g., redirect to DEVNULL) and only capturing stderr to reduce memory/IO overhead and avoid huge buffered output on larger repos.

Search results