Skip to content

add_options is annotated to take OptionManager, but the tests pass a spy object. With mypy --strict running on tests/, this will be flagged as an incompatible argument type. Consider typing parser as a small Protocol (e.g., something with add_option(...)) or Any/object + runtime duck-typing to keep both plugin correctness and test type-checking. #37

Description

@steven-cutting

add_options is annotated to take OptionManager, but the tests pass a spy object. With mypy --strict running on tests/, this will be flagged as an incompatible argument type. Consider typing parser as a small Protocol (e.g., something with add_option(...)) or Any/object + runtime duck-typing to keep both plugin correctness and test type-checking.

Originally posted by @copilot-pull-request-reviewer in #34 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions