chore(release): v0.6.5 - #431
Conversation
…-install, undo/re-transcribe, Chinese variants
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
There was a problem hiding this comment.
No issues found across 3 files
You’re at about 98% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Optic00
left a comment
There was a problem hiding this comment.
Checked the changelog and README copy against git log v0.6.4..main, and every
entry maps to a merged PR in the range: #416, #425, #392, #391, #102, #389,
#421, #363, #423, #415, #370, #390. Nothing in the range is misdescribed, the
"What's New" marquee is correctly trimmed to four, and the version bump is
consistent. The copy itself reads well.
Two things that are not in this PR but gate the tag it leads to.
1. Auto-update will push this build onto macOS 12/13 installs (#432).
This is the release-blocking one. #416 raised LSMinimumSystemVersion to 14.4,
but that floor is enforced by Launch Services at startup — nothing in the
update path checks it. A v0.6.4 install on macOS 12/13 will download v0.6.5,
install it during idle (#425), and then have an app that no longer opens.
It cannot be fixed inside the app: a build only ever runs on an OS that already
meets its own floor, so an in-app guard could never fire, and the machines at
risk are running the previous build. The manifest is what reaches them —
electron-updater checks minimumSystemVersion in latest-mac.yml before it
reports an update or downloads anything, and v0.6.3/v0.6.4 both ship
electron-updater ^6.8.3. Fix in #436.
One trap worth knowing before anyone patches this by hand: electron-updater
compares that field against os.release(), which on macOS is the Darwin
version. minimumSystemVersion: 14.4.0 is a silent no-op, because macOS 12
reports Darwin 21.6.0. It needs 23.4.0. Evidence is in #432; #436 has the
workflow change and the unit-tested translation.
2. The release body template still says macOS 12 (#434).
.github/workflows/build-release.yml has - macOS 12 (Monterey) or later in
its ### Requirements block, so every release page from this tag onward would
restate the old floor next to the download. #434 fixes that plus the website
FAQ, which #430 left behind.
Optional, same area: the template already carries an "Intel Mac users"
paragraph telling that group which version to stay on. Once #432 lands, macOS
12/13 users are in exactly the same position — stranded on v0.6.4 with
auto-update correctly refusing to move them — and an equivalent line would
answer the support question before it is asked.
Nit, take it or leave it: the PR body lists "nav security hardening (#387)"
as shipping, but there is no changelog entry for it. Fine to leave out
deliberately; just flagging the mismatch between body and changelog.
|
Suggested cut line for this tag, in the interest of shipping it soon and safely: #431 + #436 + #434, and nothing else.
Everything else we have open — #428, #422, #426, #398, #368 — is green and reviewed but not required for a safe v0.6.5. They add change surface to a release whose whole point is a raised OS floor, and they lose nothing by going into 0.6.6 right after. I also have an About-tab copy fix ready locally and am deliberately holding it back for the same reason: it touches the update error path that #435 and #436 just changed twice in one day. No opinion on the release timing itself beyond that — the branch gate ( |
Optic00
left a comment
There was a problem hiding this comment.
Re-approving after d45ffcb (my earlier approval was dismissed by that commit). Diff since then is the single changelog line, and it reads correctly.
One dependency worth stating explicitly: "Macs below macOS 14.4 are no longer offered an update they can't install" is only true for the machines at risk once #436 is in. On its own, #435's runtime gate ships inside the build that must not be installed, while the affected clients are running v0.6.4 with no gate at all. So this line and #436 should land in the same tag.
Release prep for v0.6.5: README "What's New" (rolling 4),
docs/changelog.mdxUpdate block, and version bump 0.6.4 → 0.6.5.Headline changes shipping (since v0.6.4):
Docs-and-version-only; no runtime code changes in this PR.
Summary by cubic
Release prep for v0.6.5: bump version and update README “What’s New” and
docs/changelog.mdx. Docs-only; no runtime code changes in this PR.New Features
Bug Fixes
Written for commit d45ffcb. Summary will update on new commits.