Skip to content

Release merge order - queue before next release #419

Description

@Optic00

Sequencing tracker for the open PR queue before the next release. Two files force a serial order; everything else is parallel. Check items off as they merge - rebasing the remaining main.js branches happens as each one above lands.

Update (25 Jul, morning): the queue is essentially drained. Overnight the maintainer merged #416, #391, #421, #363, #387, #393 and #395, which closes out Wave 1 and Wave 3 entirely and leaves only #398 from Wave 2. Four PRs remain open on our side, all green and review-blocked only: #398, #368, #422, #426 (the last two are new, see below).

#398 needed a third rebase - ruzin's #425 (auto-install updates) added hooks to GeneralTab.tsx at the same spot the record-hotkey hooks go. Additive, both sides kept; rebased, verified (typecheck + unit + full T1) and back to MERGEABLE.

Wave 1 - independent, green, merge in any order

Wave 2 - app/main.js chain (serial, rebase each onto the last)

Wave 3 - security + platform fixes

New since this issue was opened

Verified in a packaged build (25 Jul)

An integration build of main + all five open PRs (#398, #368, #422, #426 and the external #384) was packaged and ad-hoc signed locally. Typecheck clean, unit 255 node:test + 128 vitest, T1 55/55. Two findings worth recording:

  • Gate auto-detect to macOS 14+; reconsider app's minimum macOS #116 Part 2 confirmed on real hardware. Launch + record produced exactly two macOS prompts - Microphone, then "System Audio Recording" - and no Screen Recording prompt. The packaged Info.plist carries only NSMicrophoneUsageDescription + NSAudioCaptureUsageDescription, and askForMediaAccess is called with 'microphone' only.
  • UX nit from that test: the two prompts arrive back-to-back with no in-app context (mic and loopback are acquired in one sequence), which reads as a duplicate request. Worth explaining both in onboarding, or asking for system audio only when the toggle is enabled. Not release-critical.

Not this release

Nothing is waiting on work from our side. Remaining must-haves: #398 (finishes Wave 2) and #368.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions