Repository navigation
docs: better comments in e2e - #287
Merged
Merged
Conversation
Previous comments were useful to Scaffold's secondary audience: the maintainers of Scaffold. This targets them at Scaffold's primary audience: consumers who generated an app with it. `e2e` is useful to both, but these comments made it seem like they were included in generated apps by accident. (See stellar-scaffold/cli#638)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous comments were useful to Scaffold's secondary audience: the
maintainers of Scaffold.
This targets them at Scaffold's primary audience: consumers who
generated an app with it.
e2eis useful to both, but these comments made it seem like they wereincluded in generated apps by accident. (See stellar-scaffold/cli#638)