Skip to content

Revert "fix(stellar-scaffold-cli): rm e2e after init" - #646

Merged
chadoh merged 1 commit into
mainfrom
revert-638-fix/rm-e2e
Oct 24, 2026
Merged

chadoh merged 1 commit into
mainfrom
revert-638-fix/rm-e2e

Conversation

@chadoh

@chadoh chadoh commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

Reverts #638

We need to think more about if we want this. e2e is included in the root package.json workspaces, so it's weird if it's not there. And it does work with the generated projects and it might be useful to them.

@chadoh
chadoh marked this pull request as ready for review October 24, 2026 11:37
@chadoh
chadoh requested a review from willemneal October 24, 2026 11:37

@willemneal willemneal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think we just need to make it more useful

@chadoh

chadoh commented Oct 24, 2026

Copy link
Copy Markdown
Contributor Author

yeah, I think we just needed better comments in e2e; see stellar-scaffold/ui#287

@chadoh
chadoh merged commit 8246ddd into main Oct 24, 2026
9 checks passed
@chadoh
chadoh deleted the revert-638-fix/rm-e2e branch October 24, 2026 13:27
pselle pushed a commit that referenced this pull request Oct 25, 2026
## 🤖 New release

* `stellar-scaffold-cli`: 0.0.32 -> 0.0.33 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.0.33](stellar-scaffold-cli-v0.0.32...stellar-scaffold-cli-v0.0.33)
- 2026-10-25

### Fixed

- *(generate)* use OZ v0.8.0 examples and add their deps from crates.io
([#647](#647))
- *(stellar-scaffold-cli)* rm e2e after `init`
([#638](#638))

### Other

- Revert "fix(stellar-scaffold-cli): rm e2e after `init`"
([#646](#646))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: aha-release-plz[bot] <211513279+aha-release-plz[bot]@users.noreply.github.com>
@zachfedor

Copy link
Copy Markdown
Contributor

Agreed, I'm glad this is back in. I want to rename it tests and add a sub-directory for unit tests. Get some actual good testing patterns in here with TestingLibrary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants