Repository navigation
fix: scaffold.yml v2 fast-follows for the 1.0 preview - #283
Merged
Merged
Conversation
zachfedor
added
the
cross-repo
Contributor
This is obviously a problem, but I wonder if it's more of a documentation problem. In our handout for the hackathon, I included this line: 
If we get better at reminding people to do this in our docs, I think we might want the opposite of this PR: rather than removing @pselle wdyt? |
Contributor
|
Edited: (if you got an email, this comment completely changed!) Sorry now I get it -- so that we don't accidentally have a bunch of projects saying The Aha Company etc. But perhaps we should have a fake company there, like ACME Corp? Or comments? Something to it's not us but gives people a placeholder to replace? |
Contributor
|
Something like commented so that it doesn't end up published on accident |
Contributor
|
side note: the cargo.lock here seems to have extra noise, might want to check on that if you push to this or replace the PR with another PR |
chadoh
force-pushed
the
fix/scaffold-v2-quick-fixes
branch
2 times, most recently
from
October 22, 2026 15:53
2ab9408 to
348cdfd
Compare
pselle
reviewed
Oct 22, 2026
pselle
reviewed
Oct 22, 2026
chadoh
marked this pull request as draft
October 22, 2026 17:16
chadoh
added a commit
to stellar-scaffold/cli
that referenced
this pull request
Oct 22, 2026
Fast-follow fixes and improvements for `scaffold.yml` v2 which didn't make the Q3 deadline and were planned/proposed for early Q4, ahead of the hackathon release. - `init` copies `app/.env.example` to `app/.env`; `doctor` checks there too. Fixes #568 - `init` builds with the project's `rust-toolchain.toml`, so the first `npm start` no longer redeploys every contract - `watch` rebuilds on editors that save by renaming over the file - `init` and `doctor` check Docker and the local network for v2 projects with any locally run network. Part of #621 (extensions check still to do), part of #604 - `init` shows its build output with `-v` or `-vv`. Part of #604 - `init` names the network it deploys to and warns that the first local run downloads the quickstart image (stellar-scaffold/ui#216) - Docs revert to recommending `cargo binstall` first and list the remaining prerequisites (C toolchain, Linux system libraries). This is a revert of a revert when we had those lagging binstall release issues. Pairs with stellar-scaffold/ui#283. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01QhmaWLv4yExX8LahP5UtUb --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com> Co-authored-by: Warp <agent@warp.dev>
The example contracts inherited `authors` and `repository` from the workspace, set to The Aha Company and the Scaffold CLI repo. Their `cargo_inherit` metadata writes those into the Wasm, so contracts built or published from a new project claimed to come from us. Projects now start with these values and also `homepage` set to blank values, and all member contracts set to inherit them, with a comment in the root Cargo.toml telling people to set the values. Corresponding change stellar-scaffold/cli#640 ensures blank `home_domain` and `source_repo` values don't end up in the Wasm.
chadoh
force-pushed
the
fix/scaffold-v2-quick-fixes
branch
from
October 22, 2026 20:25
152244c to
32c69cd
Compare
chadoh
marked this pull request as ready for review
October 22, 2026 20:25
chadoh
removed
the
cross-repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fast-follow fixes for
scaffold.ymlv2, planned or found during Q3 and proposed for early Q4, ahead of the pre-hackathon release.authorsandrepository, whichcargo_inheritwrote into every contract's Wasm metadataPairs with stellar-scaffold/cli#632.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QhmaWLv4yExX8LahP5UtUb