Repository navigation
feat(stellar-scaffold-cli): don't write empty meta - #640
Merged
Merged
Conversation
If `homepage` or `repository` are blank in Cargo.toml, do not write their corresponding `meta` fields in the Wasm
Contributor
|
Why is this bad though? if the user explicitly set a blank string, is there a negative outcome to this? The |
chadoh
added a commit
to stellar-scaffold/ui
that referenced
this pull request
Oct 22, 2026
The example contracts inherited `authors` and `repository` from the workspace, set to The Aha Company and the Scaffold CLI repo. Their `cargo_inherit` metadata writes those into the Wasm, so contracts built or published from a new project claimed to come from us. Projects now start with these values and also `homepage` set to blank values, and all member contracts set to inherit them, with a comment in the root Cargo.toml telling people to set the values. Corresponding change stellar-scaffold/cli#640 ensures blank `home_domain` and `source_repo` values don't end up in the Wasm.
Contributor
Author
|
@pselle see newimproved stellar-scaffold/ui#283 (relevant commit now shown here in this PR's history, too): I wanted to include the Def not a big deal, but it's a quick fix so we may as well. |
Contributor
Author
|
mettling! bc release builds take forever and they just started after #632 merge so we may as well have this lil cherry on top before they spend an hour building latest CLI artifacts |
chadoh
added a commit
to stellar-scaffold/ui
that referenced
this pull request
Oct 22, 2026
The example contracts inherited `authors` and `repository` from the workspace, set to The Aha Company and the Scaffold CLI repo. Their `cargo_inherit` metadata writes those into the Wasm, so contracts built or published from a new project claimed to come from us. Projects now start with these values and also `homepage` set to blank values, and all member contracts set to inherit them, with a comment in the root Cargo.toml telling people to set the values. Corresponding change stellar-scaffold/cli#640 ensures blank `home_domain` and `source_repo` values don't end up in the Wasm.
chadoh
added a commit
to stellar-scaffold/ui
that referenced
this pull request
Oct 23, 2026
The example contracts inherited `authors` and `repository` from the workspace, set to The Aha Company and the Scaffold CLI repo. Their `cargo_inherit` metadata writes those into the Wasm, so contracts built or published from a new project claimed to come from us. Projects now start with these values and also `homepage` set to blank values, and all member contracts set to inherit them, with a comment in the root Cargo.toml telling people to set the values. Corresponding change stellar-scaffold/cli#640 ensures blank `home_domain` and `source_repo` values don't end up in the Wasm. Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
chadoh
pushed a commit
that referenced
this pull request
Oct 23, 2026
## 🤖 New release * `stellar-scaffold-cli`: 0.0.31 -> 0.0.32 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.0.32](stellar-scaffold-cli-v0.0.31...stellar-scaffold-cli-v0.0.32) - 2026-10-23 ### Added - *(stellar-scaffold-cli)* don't write empty meta ([#640](#640)) ### Fixed - scaffold.yml v2 fast-follows for the 1.0 preview ([#632](#632)) - *(cli)* use the stellar-scaffold name in help and version output ([#636](#636)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: aha-release-plz[bot] <211513279+aha-release-plz[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
homepageorrepositoryare blank in Cargo.toml, do not writetheir corresponding
metafields in the Wasm