Skip to content

fix(statistics): align geographic grouping and show missing-parent entries - #575

Merged
stef-k merged 2 commits into
mainfrom
fix/location-statistics-grouping
Sep 5, 2026
Merged

fix(statistics): align geographic grouping and show missing-parent entries#575
stef-k merged 2 commits into
mainfrom
fix/location-statistics-grouping

Conversation

@stef-k

@stef-k stef-k commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Location summaries counted bare names while details grouped by parents, and Timeline hid groups with missing parents. Use one database-side normalization/grouping definition across summary and detail statistics, show missing-parent sections, and select one settlement representative deterministically when timestamps tie.

Trim only outer ASCII whitespace and apply the single approved read-time correction from East Macedonia and Thrace to Eastern Macedonia and Thrace under exact country Greece. Preserve original records, API shapes, date semantics, search/edit behavior and #572 mappings. No migrations, data rewrite, new identity infrastructure or provider contact. Closes #573.

Validation:

  • Independent review READY FOR PR at 4356848, no reachable blockers across all ten files.
  • Fresh reviewer selection: 35 service/controller tests with PostgreSQL enabled, zero skips; 2 production-renderer client tests. Both complete Timeline callers bundle successfully in memory.
  • Retained behavioral red demonstrates summary/grouping mismatch and hidden-parent rendering. Retained 109-test compatibility and other selections overlap; totals are not additive.
  • PostgreSQL proof verifies unchanged stored scalar values, user/date membership, ordered averages and tied representative selection. Parameterized queries, C collation and ordinal output tie-breakers inspected.
  • Code Guard complete-branch REVIEW only: cohesive aggregation/rendering, existing Timeline callables and allowances, historical changelog. No FAIL/INCOMPLETE or policy/baseline changes. Whitespace passed.

Limits: local generated dist bundles are stale and are not current-head evidence. Fresh bundling and inspected Release/publish/static-serving conventions cover integration; no published/browser observation or screenshot is available. No full-suite-green claim. Statistics still represent recorded parent-scoped labels, not universal geographic identity; same-named settlements under identical parents remain indistinguishable and other aliases can still split entities.

Merge gate: successful GitHub Actions test on the exact current PR head.

@stef-k
stef-k merged commit 49ea22e into main Sep 5, 2026
1 check passed
@stef-k
stef-k deleted the fix/location-statistics-grouping branch September 5, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct Location statistics grouping and the Greece region-label duplicate without rewriting source data

1 participant