fix(locations): separate Geoapify address fields and retained feature display - #574
Merged
Conversation
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Geoapify display strings could place a nearby POI name in the street-address field and give it undue prominence in Location views. Map structured street/number, settlement and state fields according to their meaning; retain FullAddress compatibility and independently preserve address_line1 as ProviderAddressLine1. Compose Geoapify Location addresses from structured components and show qualified feature text below them across Location, Timeline, public/embed, group and edit-summary surfaces.
Preserve historical stored values, fill-only repair, manual-edit authority, Mapbox mappings/display and Trip FullAddress preference. Add the retained line to Location projections and backend format round trips. Fix CSV publication timestamp encoding and preserve internal retained-line whitespace across imports; XML formats normalize CRLF to LF.
Closes #572. #573 region identity/statistics and #505 Mobile coordination remain outside scope.
Migration: 20260905095140_AddLocationProviderAddressLine1 adds only nullable Locations.ProviderAddressLine1 varchar(500), with matching model/snapshot. No historical data rewrite. Applied only through the dedicated test prerequisite; production migration/deployment not performed.
Validation:
Visual evidence: reviewer rendered the production formatter with Bootstrap and Location modal wrapper at 360px; feature text was below the address, 14px versus 16px, muted, with no horizontal overflow. Screenshot retained locally at .local/issue572-independent-wrapping.png; no public image URL attached. Authenticated full-page/Edit mounting remains unobserved, independently assessed as nonblocking given lower-seam coverage.
Limits: no full-suite-green claim. No historical provider-response completeness claim, production access/provider contact, or Mobile modification. Released Mobile preserves existing fields but cannot promise unknown-field retention through its own offline formats.
Merge gate: GitHub Actions test succeeds on the exact current PR head.