Skip to content

fix(locations): separate Geoapify address fields and retained feature display - #574

Merged
stef-k merged 4 commits into
mainfrom
fix/geoapify-location-field-mapping
Sep 5, 2026
Merged

fix(locations): separate Geoapify address fields and retained feature display#574
stef-k merged 4 commits into
mainfrom
fix/geoapify-location-field-mapping

Conversation

@stef-k

@stef-k stef-k commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Geoapify display strings could place a nearby POI name in the street-address field and give it undue prominence in Location views. Map structured street/number, settlement and state fields according to their meaning; retain FullAddress compatibility and independently preserve address_line1 as ProviderAddressLine1. Compose Geoapify Location addresses from structured components and show qualified feature text below them across Location, Timeline, public/embed, group and edit-summary surfaces.

Preserve historical stored values, fill-only repair, manual-edit authority, Mapbox mappings/display and Trip FullAddress preference. Add the retained line to Location projections and backend format round trips. Fix CSV publication timestamp encoding and preserve internal retained-line whitespace across imports; XML formats normalize CRLF to LF.

Closes #572. #573 region identity/statistics and #505 Mobile coordination remain outside scope.

Migration: 20260905095140_AddLocationProviderAddressLine1 adds only nullable Locations.ProviderAddressLine1 varchar(500), with matching model/snapshot. No historical data rewrite. Applied only through the dedicated test prerequisite; production migration/deployment not performed.

Validation:

  • Full independent review found one retention blocker; focused re-review at bd1ce14 confirms it resolved and returns READY FOR PR, no reachable new defect.
  • Full reviewer freshly passed 248 focused backend tests including PostgreSQL, 117 client tests, frontend builds and model consistency checks before remediation.
  • Re-review freshly passed 115 focused format/parser, tuple-import and Geoapify tests, zero failures/skips. Eight actual exporter-to-parser red cases were retained before remediation. Counts overlap and are not additive.
  • Four-format round trips cover LF/CRLF, tabs, Unicode and escaping, preserving historical address strings and provenance.
  • Code Guard complete-branch REVIEW only; accepted existing orchestration, cohesive mappings and historical changelog within committed allowances. No FAIL/INCOMPLETE or policy/baseline changes. Whitespace checks passed.

Visual evidence: reviewer rendered the production formatter with Bootstrap and Location modal wrapper at 360px; feature text was below the address, 14px versus 16px, muted, with no horizontal overflow. Screenshot retained locally at .local/issue572-independent-wrapping.png; no public image URL attached. Authenticated full-page/Edit mounting remains unobserved, independently assessed as nonblocking given lower-seam coverage.

Limits: no full-suite-green claim. No historical provider-response completeness claim, production access/provider contact, or Mobile modification. Released Mobile preserves existing fields but cannot promise unknown-field retention through its own offline formats.

Merge gate: GitHub Actions test succeeds on the exact current PR head.

@stef-k
stef-k merged commit 6ef7fe0 into main Sep 5, 2026
1 check passed
@stef-k
stef-k deleted the fix/geoapify-location-field-mapping branch September 5, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct Location provider field mapping and separate addresses from nearby feature presentation

1 participant