Skip to content

fix(browser): isolate daemon from shell process group - #122

Closed
danew wants to merge 1 commit into
dane/ste-3049-device-auth-minimalfrom
dane/browser-daemon-process-group-review
Closed

danew wants to merge 1 commit into
dane/ste-3049-device-auth-minimalfrom
dane/browser-daemon-process-group-review

Conversation

@danew

@danew danew commented Oct 28, 2026

Copy link
Copy Markdown

Summary

  • Start the browser daemon in its own Unix process group so shell-tool cleanup cannot terminate it between separate CLI commands.
  • Preserve existing native browser behavior and explicit session release; no client-specific launch wrappers or permission changes.
  • Extend the native API/CDP integration regression to verify that the daemon owns its process group.

Validation

  • Targeted daemon unit tests and token-only native API/CDP integration passed in the combined candidate.
  • Actual native-client process-lifetime regression reproduced the failure before this change and passed after it; a second client remained passing as a control.
  • Formatting and whitespace checks passed.

Stack and release gate

  • Stacked on feat(auth): support first-party device login #120; the diff contains only the daemon fix and its regression assertion, not the unrelated skill-discovery change.
  • Draft only. Do not merge or release until the authentication changes are in production and the release owner approves.
  • Retarget to main after the dependency is merged; no production release is claimed.

@junhsss

junhsss commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

closing this since the daemon is gone now

@junhsss junhsss closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants