Skip to content

fix(browser): use actionable native click dispatch - #123

Closed
danew wants to merge 1 commit into
dane/browser-daemon-process-group-reviewfrom
dane/browser-click-actionability-review
Closed

danew wants to merge 1 commit into
dane/browser-daemon-process-group-reviewfrom
dane/browser-click-actionability-review

Conversation

@danew

@danew danew commented Oct 28, 2026

Copy link
Copy Markdown

Summary

  • Pin the native browser engine to the reviewed click-actionability candidate: fix(native): validate click actionability before dispatch agent-browser#1.
  • Targets are scrolled and checked before pointer dispatch, with existing frame coordinates preserved and useful validation failures.
  • Keep the existing clicked response contract; navigation and task completion remain explicit observations rather than universal click requirements.

Validation

  • Dependency-pin files exactly match the combined candidate used for testing.
  • Consumer CLI library: 359 passed; 8 existing ignored. Lifecycle/auth integrations: 25 passed.
  • Actual Chromium regressions cover visible/off-screen original-reference activation, covered/disabled targets, DOM-only buttons, new tabs, frames and asymmetric padding.
  • One live candidate scenario passed without caller scrolling, direct-href navigation or JavaScript-click workarounds; destination and exact owned-session release were checked independently.
  • Native-client compatibility used scripted local providers and is separate from live model/autonomy coverage.

Stack and release gate

@junhsss

junhsss commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

closing this since agent-browser is no longer part of the cli

@junhsss junhsss closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants