Repository navigation
test(native-chat): paired-host permission tests use an agent that still has no chat modes - #29891
Merged
Merged
Conversation
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Two tests on main checked a rule using Grok as "an agent whose chats have no permission modes". A change merged the same day gave Grok chats their own modes, so the tests now fail on every PR. They use Gemini instead, which still has none.
What Changed
Test-only. No product behaviour changes.
structured-chat-host-permission.test.ts("asks nothing ... for an agent without chat modes") andagent-chat-permission-host-support.test.ts("names no mode for an agent without chat modes") fail on main. After: both pass, with Gemini as the agent that has no modes.Why
#29335 meant to give Grok modes, and putting Grok's chats through the older-host check is the right result, so the product stays as is and the tests change. No released tag includes #29442 without #29335, so no released host advertises per-chat modes but ignores Grok's mode.
The other reported breakage,
max-linesonstructured-agent-session-host.ts, was already fixed on main by #29869. Rootoxlintpasses on current main.Linked Issue
N/A: main was red, no issue filed.
Visual Proof
N/A: test-only change.
Testing
pnpm test src/renderer/src/runtime src/main/native-chat --maxWorkers=1: 656 files, 5969 tests passed.pnpm test src/shared/agent-chat-permission --maxWorkers=1: passed.Static-analysis job steps run locally (oxlint, anti-slop, native and type-aware plugins, changed-code quality, React Doctor, max-lines / ts-nocheck / runtime-electron / focus-read / layout-writer ratchets, catalogs, localization, etc.): all passed. Typecheck passed through
pnpm tc(the bun-compiler varianttypecheck:cifails locally for an environment reason, "Script not found check").I manually tested these changes locally
Automated tests added/updated, or explained why not below