Skip to content

test(native-chat): paired-host permission tests use an agent that still has no chat modes - #29891

Merged
nwparker merged 1 commit into
mainfrom
nwparker/fix-main-session-host-lines
Oct 16, 2026
Merged

nwparker merged 1 commit into
mainfrom
nwparker/fix-main-session-host-lines

Conversation

@nwparker

@nwparker nwparker commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 2 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​6 $\color{#cf222e}{\Huge{\mathbf{−}}}$​4 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​2
Prod 0 0 0 0

ELI5

Two tests on main checked a rule using Grok as "an agent whose chats have no permission modes". A change merged the same day gave Grok chats their own modes, so the tests now fail on every PR. They use Gemini instead, which still has none.

What Changed

Test-only. No product behaviour changes.

Why

#29335 meant to give Grok modes, and putting Grok's chats through the older-host check is the right result, so the product stays as is and the tests change. No released tag includes #29442 without #29335, so no released host advertises per-chat modes but ignores Grok's mode.

The other reported breakage, max-lines on structured-agent-session-host.ts, was already fixed on main by #29869. Root oxlint passes on current main.

Linked Issue

N/A: main was red, no issue filed.

Visual Proof

N/A: test-only change.

Testing

  • pnpm test src/renderer/src/runtime src/main/native-chat --maxWorkers=1: 656 files, 5969 tests passed.

  • pnpm test src/shared/agent-chat-permission --maxWorkers=1: passed.

  • Static-analysis job steps run locally (oxlint, anti-slop, native and type-aware plugins, changed-code quality, React Doctor, max-lines / ts-nocheck / runtime-electron / focus-read / layout-writer ratchets, catalogs, localization, etc.): all passed. Typecheck passed through pnpm tc (the bun-compiler variant typecheck:ci fails locally for an environment reason, "Script not found check").

  • I manually tested these changes locally

  • Automated tests added/updated, or explained why not below

… permission tests

#29335 gave Grok chats their own permission modes, so on a paired host
that predates per-chat modes a Grok chat is now checked like Claude and
Codex; that is intended. #29442's tests, merged a day earlier, used Grok
as the agent without modes. Use Gemini, which still has none.
@nwparker
nwparker merged commit e23cfcd into main Oct 16, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant