Repository navigation
test: use an agent without chat modes now Grok has them - #29888
Closed
brennanb2025 wants to merge 1 commit into
Closed
brennanb2025 wants to merge 1 commit into
brennanb2025 wants to merge 1 commit into
Conversation
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 27 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 16, 2026
Contributor
Author
|
Closing: the same fix landed on main as #29891. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Main's unit tests fail on every PR right now:
src/shared/agent-chat-permission-host-support.test.ts› "names no mode for an agent without chat modes": expected'full-access'to be null.src/renderer/src/runtime/structured-chat-host-permission.test.ts› "asks nothing for this machine, or for an agent without chat modes": expected{ kind: 'unverified' }to equal{ kind: 'allowed' }.Two PRs that each passed alone broke main together. #29442 (never run a chat on an older host with more access than Ask allows) used Grok as its example of "an agent without chat modes". #29335 (OMP, OpenCode and Grok chats follow their own permission mode) then gave Grok chat modes, so Grok is no longer that example.
User-facing change
None. Only the tests change. The production behaviour on main is the intended one: Grok chats now have modes, so the older-host safety check applies to them too.
What changed
The three test cases that mean "an agent with no chat modes" now use Gemini, which still has none, instead of Grok.
Testing
CI on this PR. Seen failing on #29095's run 38980998021 (unit shards 3/5 and 4/5).