Skip to content

test: use an agent without chat modes now Grok has them - #29888

Closed
brennanb2025 wants to merge 1 commit into
mainfrom
brennanb2025/fix-main-chat-modes-tests
Closed

brennanb2025 wants to merge 1 commit into
mainfrom
brennanb2025/fix-main-chat-modes-tests

Conversation

@brennanb2025

@brennanb2025 brennanb2025 commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 2 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​7 $\color{#cf222e}{\Huge{\mathbf{−}}}$​5 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​2
Prod 0 0 0 0

Problem

Main's unit tests fail on every PR right now:

  • src/shared/agent-chat-permission-host-support.test.ts › "names no mode for an agent without chat modes": expected 'full-access' to be null.
  • src/renderer/src/runtime/structured-chat-host-permission.test.ts › "asks nothing for this machine, or for an agent without chat modes": expected { kind: 'unverified' } to equal { kind: 'allowed' }.

Two PRs that each passed alone broke main together. #29442 (never run a chat on an older host with more access than Ask allows) used Grok as its example of "an agent without chat modes". #29335 (OMP, OpenCode and Grok chats follow their own permission mode) then gave Grok chat modes, so Grok is no longer that example.

User-facing change

None. Only the tests change. The production behaviour on main is the intended one: Grok chats now have modes, so the older-host safety check applies to them too.

What changed

The three test cases that mean "an agent with no chat modes" now use Gemini, which still has none, instead of Grok.

Testing

CI on this PR. Seen failing on #29095's run 38980998021 (unit shards 3/5 and 4/5).

#29335 gave Grok chats Ask/Full access modes, so the older-host
permission tests from #29442 that used Grok as "an agent without chat
modes" now fail on main. Use Gemini, which still has none.
@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9a3d7b22-e5c7-4e7f-98b8-925cfa7927f5
📥 Commits

Reviewing files that changed from the base of the PR and between d963f2a and cd6203c.

📒 Files selected for processing: 2
  • src/renderer/src/runtime/structured-chat-host-permission.test.ts
  • src/shared/agent-chat-permission-host-support.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@brennanb2025

Copy link
Copy Markdown
Contributor Author

Closing: the same fix landed on main as #29891.

@brennanb2025
brennanb2025 deleted the brennanb2025/fix-main-chat-modes-tests branch October 17, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant