시뮬레이션 루프 종료 전 다음 사이클 프리뷰 렌더링#23
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 Walkthrough개요시뮬레이션 프레임 렌더링이 변경 사항시뮬레이션 렌더 파이프라인 프리뷰 오버랩
🎯 3 (Moderate) | ⏱️ ~25 분 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/features/simulation/model/sim-domain-adapter.ts (1)
253-257: ⚡ Quick win프리뷰 오버랩 유틸리티가 두 파일에 중복 정의되어 있습니다.
MAX_PREVIEW_OVERLAP_TICKS상수와previewOverlapTicks함수가sim-domain-adapter.ts와use-sim-run.ts양쪽에 동일하게 정의되어 있습니다. 값이나 로직이 불일치할 경우 프리뷰 오버랩 동작이 파일 간에 달라질 수 있습니다.공통 유틸리티 파일(예:
sim-preview-utils.ts)로 추출하여 단일 소스를 유지하는 것을 권장합니다.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/features/simulation/model/sim-domain-adapter.ts` around lines 253 - 257, Extract the duplicated MAX_PREVIEW_OVERLAP_TICKS constant and previewOverlapTicks(manifest: SimManifest) function into a single shared utility module (e.g., sim-preview-utils.ts), export them, then remove the local definitions and import the shared exports where both current copies are used; ensure the exported function signature and constant value remain the single source of truth and update any references to call previewOverlapTicks and use MAX_PREVIEW_OVERLAP_TICKS from the shared module.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/features/simulation/model/sim-domain-adapter.ts`:
- Around line 253-257: Extract the duplicated MAX_PREVIEW_OVERLAP_TICKS constant
and previewOverlapTicks(manifest: SimManifest) function into a single shared
utility module (e.g., sim-preview-utils.ts), export them, then remove the local
definitions and import the shared exports where both current copies are used;
ensure the exported function signature and constant value remain the single
source of truth and update any references to call previewOverlapTicks and use
MAX_PREVIEW_OVERLAP_TICKS from the shared module.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8eeeafed-f78c-4339-8f51-b02b31139f06
📒 Files selected for processing (2)
src/features/simulation/model/sim-domain-adapter.tssrc/features/simulation/model/use-sim-run.ts
작업 내용
projection_tail_ticks기반 preview window에서 다음 cycle agent/persona를 함께 렌더링합니다.의도
검증
pnpm lint -- src/features/simulation/model/use-sim-run.ts src/features/simulation/model/sim-domain-adapter.tspnpm test -- --runInBandpnpm buildgit diff --checkSummary by CodeRabbit
릴리스 노트
새로운 기능
개선