Skip to content

gettext: Remove obsolete source metadata workarounds - #14633

Open
jdillard wants to merge 2 commits into
sphinx-doc:masterfrom
jdillard:remove-4913-workaround
Open

gettext: Remove obsolete source metadata workarounds#14633
jdillard wants to merge 2 commits into
sphinx-doc:masterfrom
jdillard:remove-4913-workaround

Conversation

@jdillard

@jdillard jdillard commented Aug 22, 2026

Copy link
Copy Markdown
Member

Purpose

Docutils now provides source and line metadata for the following nodes across all versions currently supported by Sphinx (>=0.21,<0.23):

  • Literal blocks nested under bullet lists
  • Rubric directives
  • Images in substitutions and nested directives

This removes the corresponding obsolete source-metadata workarounds and the regression test that only exercised the removed literal-block fallback. Existing gettext and message-extraction tests continue to cover these cases.

The workarounds for line nodes and field names remain because supported Docutils versions still omit their metadata.

References

AI Disclosure

AI was used to investigate whether the workarounds remain necessary and draft the implementation. I reviewed and validated the changes.

@jdillard jdillard changed the title gettext: Remove obsolete literal-block source workaround gettext: Remove obsolete source metadata workarounds Aug 22, 2026
@jdillard
jdillard force-pushed the remove-4913-workaround branch from 9decf66 to f1ee7c5 Compare August 22, 2026 18:25
@jdillard jdillard added the docutils Tags upstream Docutils issues label Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docutils Tags upstream Docutils issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant