gettext: Remove obsolete source metadata workarounds - #14633
Open
jdillard wants to merge 2 commits into
Open
Conversation
jdillard
force-pushed
the
remove-4913-workaround
branch
from
August 22, 2026 18:25
9decf66 to
f1ee7c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Docutils now provides
sourceandlinemetadata for the following nodes across all versions currently supported by Sphinx (>=0.21,<0.23):This removes the corresponding obsolete source-metadata workarounds and the regression test that only exercised the removed literal-block fallback. Existing gettext and message-extraction tests continue to cover these cases.
The workarounds for line nodes and field names remain because supported Docutils versions still omit their metadata.
References
AI Disclosure
AI was used to investigate whether the workarounds remain necessary and draft the implementation. I reviewed and validated the changes.