gettext: Extract indented doctest blocks - #14632
Open
jdillard wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Docutils does not set
sourcemetadata on doctest blocks nested in block quotes, which is how indented doctest blocks are parsed. Consequently, gettext skips these blocks even whendoctest-blockis enabled ingettext_additional_targets. Docutils tracks the underlying inconsistentsourceandlinemetadata in feature request #41.Extend the existing source-metadata workaround for literal blocks to cover doctest blocks, and add regression coverage. Sphinx still needs this workaround for supported Docutils releases.
Note
Prefer merging #14633 first because it removes the obsolete literal-block workaround modified by this PR. Afterward, this PR can rebase to add a
doctest_block-only workaround.References
AI Disclosure
AI was used to investigate the root cause and draft the implementation. I reviewed and validated the changes.