chore: remove the geonovum profile - #5430
Merged
Merged
Conversation
marcoscaceres
force-pushed
the
chore/remove-geonovum-profile
branch
from
August 25, 2026 04:47
749c47a to
7bfd44b
Compare
sidvishnoi
approved these changes
Aug 25, 2026
marcoscaceres
marked this pull request as ready for review
August 25, 2026 09:10
marcoscaceres
enabled auto-merge (squash)
August 26, 2026 05:24
Contributor
Author
|
Going to merge and we can revert if we need to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Geonovum appears to have moved off this profile. Their current document template, Geonovum/NL-ReSpec-template, loads a base build from Logius (respec-nlgov.js) together with their own config scripts and does not reference this profile; the older template that did is one they themselves describe as "Oude, gearchiveerde". Older Geonovum documents still reference respec-geonovum in about a dozen of their repositories, and the one I opened points at their own copy on tools.geostandaarden.nl rather than at ours. That copy reports ReSpec 24.5.2 and still contains the geonovum/headers, informative, inlines, leafletfigures and seo modules this profile has since lost, so it is self-contained and unaffected by this removal.
Meanwhile the in-tree profile has rotted to the point of being unusable. It imports no geonovum/headers.js, so a document rendered with it has no title h1, no div.head and no Abstract or SoTD heading, and ReSpec reports zero errors while producing that. It went unnoticed because the Geonovum tests were loading the W3C bundle, which was #5409, fixed in #5428.
This removes the profile source, its tests and its build wiring, but deliberately leaves the prebuilt
builds/respec-geonovum.jsin place. CI rejects any change underbuilds/in a pull request, and the release tooling only ever writes bundles rather than deleting them, so the artifact stays andhttps://speced.github.io/respec/builds/respec-geonovum.jskeeps serving. Anything already pointing at that URL therefore continues to render, which seemed the safer default given I have no data on whether anything still requests it. Removing the stale artifact can be a separate decision.I have asked Geonovum directly whether they still need it: Geonovum/NL-ReSpec-template#48.
Separately, and not addressed here: a profile finishing without a title while reporting no error looks like a core problem rather than a Geonovum-specific one. dini and aom each import their own headers module today, so they are fine, but nothing in the pipeline would catch it if one of them lost that import the same way.