Skip to content

chore: drop geonovum from the copilot setup steps and instructions - #5438

Merged
marcoscaceres merged 1 commit into
mainfrom
fix/copilot-setup-geonovum
Aug 28, 2026
Merged

chore: drop geonovum from the copilot setup steps and instructions#5438
marcoscaceres merged 1 commit into
mainfrom
fix/copilot-setup-geonovum

Conversation

@marcoscaceres

Copy link
Copy Markdown
Contributor

Removing the geonovum profile in #5430 left pnpm build:geonovum in the Copilot setup steps, so every Copilot code review since then has failed setup and run without the aom and dini bundles or a browser. This drops it from the workflow and from the agent instructions, which still told agents to build that profile and to register new modules in a profile that no longer exists.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Copilot’s automated setup and agent guidance to reflect the removal of the Geonovum profile, ensuring setup succeeds and agents build the correct bundles for running tests.

Changes:

  • Remove pnpm build:geonovum from the Copilot setup workflow build steps.
  • Update .github/copilot-instructions.md to remove Geonovum from the recommended build sequence and module-registration guidance.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/copilot-setup-steps.yml Drops the Geonovum bundle build so Copilot setup no longer fails on a removed profile.
.github/copilot-instructions.md Aligns build/test and module-registration instructions with the remaining profiles (w3c/aom/dini).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Run {

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copilot AI commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Run {

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

@marcoscaceres
marcoscaceres merged commit 3322399 into main Aug 28, 2026
11 of 13 checks passed
@marcoscaceres
marcoscaceres deleted the fix/copilot-setup-geonovum branch August 28, 2026 06:40
@marcoscaceres

Copy link
Copy Markdown
Contributor Author

Was breaking poor copilot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants