[Link Event Damping] Add config/show/clear CLI commands by DendroLabs · Pull Request #4367 · sonic-net/sonic-utilities

DendroLabs · 2026-03-17T14:36:28Z

Summary

Supersedes #3001 by @Ashish1805. Adds complete CLI support for the Link Event Damping feature (HLD: sonic-net/SONiC#1071).

All review feedback from #3001 has been addressed:

Uses click.IntRange for parameter validation (@Junchao-Mellanox)
Rebased onto current master (@prsunny)
Added show command that was flagged as missing (@Junchao-Mellanox)

Commands added:

config interface dampening <interface> enable [options]

Enables AIED dampening with industry-standard defaults (half-life=5s, reuse=1000, suppress=2000, max-suppress=20s, penalty=1000)
--monitor flag enables monitor-only mode (RFC 7196 "Calculate But Do Not Damp")
Validates: interface exists, reuse < suppress, half-life <= max-suppress-time

config interface dampening <interface> disable

Disables dampening on the interface

show interfaces dampening [interface_name]

Displays config parameters and operational state (current penalty, suppressed status, time remaining)
Shows "(Mon)" for monitor-only mode interfaces
Shows per-interface dampening counters when querying a specific port

sonic-clear interfaces dampening [interface_name]

Resets penalty to 0 and immediately unsuppresses
Standard across Cisco/Juniper; recommended by RFC 2439

New features not in any other NOS vendor:

Monitor-only mode (--monitor): Calculates penalties and emits syslog but does NOT suppress events. Allows safe parameter tuning in production. Recommended by RFC 7196; no vendor has implemented this.
Syslog integration: Syncd emits WARNING on suppress, NOTICE on unsuppress (addresses use new file location for sys eeprom and sfp eeprom on msn2700 #1 industry complaint about silent suppression)

Test plan

config interface dampening enable writes correct fields to CONFIG_DB PORT table
config interface dampening disable resets all fields
config interface dampening enable --monitor sets algorithm to "aied-monitor"
Parameter validation rejects invalid combinations (reuse >= suppress, etc.)
show interfaces dampening displays configured interfaces
show interfaces dampening <port> shows counters
sonic-clear interfaces dampening writes clear flag to STATE_DB
Existing sonic-utilities tests pass (no regressions)

🤖 Generated with Claude Code

Co-Authored-By: Ashish Singh ashish.singh@google.com

mssonicbld · 2026-03-17T14:36:39Z

/azp run

linux-foundation-easycla · 2026-03-17T14:36:45Z

The committers listed above are authorized under a signed CLA.

✅ login: DendroLabs / name: DendroLabs (1895b3a, 4358624, 456be04, 6eaf7a0, f484733)

azure-pipelines · 2026-03-17T14:36:52Z

Azure Pipelines successfully started running 1 pipeline(s).

@Junchao-Mellanox

Implements CLI support for RFC 2439/7196 link event dampening: - config interface dampening enable/disable: configure AIED dampening with validation (IntRange per review feedback), monitor-only mode, and configurable flap-penalty - show interfaces dampening: display config and operational state from CONFIG_DB and STATE_DB with per-interface counters - sonic-clear interfaces dampening: reset penalty via STATE_DB flag Supersedes sonic-net#3001 with improvements: - click.IntRange validation (per @Junchao-Mellanox review) - Monitor-only mode per RFC 7196 "Calculate But Do Not Damp" - Configurable flap-penalty (vs hardcoded 1000) - Show command with operational state and counters - Clear command per RFC 2439 Section 4.8.6 Signed-off-by: DendroLabs <info@dendrolabs.com>

- Guard against exponential overflow in ceiling calculation - Add interface alias support to clear command - Improve error handling consistency Signed-off-by: DendroLabs <info@dendrolabs.com>

mssonicbld · 2026-03-17T15:57:17Z

/azp run

azure-pipelines · 2026-03-17T15:57:29Z

Azure Pipelines successfully started running 1 pipeline(s).

DendroLabs · 2026-03-17T16:08:43Z

/easycla

- Add missing blank line before dampening subgroup (E302) - Fix continuation line indentation in warning messages (E127) Signed-off-by: DendroLabs <info@dendrolabs.com>

mssonicbld · 2026-03-17T16:11:46Z

/azp run

azure-pipelines · 2026-03-17T16:11:59Z

Azure Pipelines successfully started running 1 pipeline(s).

Tests cover config enable/disable, show, and clear commands: - Config: defaults, custom params, monitor mode, validation (invalid interface, reuse>=suppress, half-life>max-suppress, IntRange bounds, overflow warning) - Show: no config, disabled, configured, monitor mode display - Clear: specific interface, all interfaces, no config, invalid Signed-off-by: DendroLabs <info@dendrolabs.com>

mssonicbld · 2026-03-17T17:26:19Z

/azp run

azure-pipelines · 2026-03-17T17:26:32Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: DendroLabs <info@dendrolabs.com>

mssonicbld · 2026-03-17T17:57:08Z

/azp run

azure-pipelines · 2026-03-17T17:57:20Z

Azure Pipelines successfully started running 1 pipeline(s).

DendroLabs · 2026-06-08T16:10:29Z

Hi @prsunny @Junchao-Mellanox — friendly ping on this PR. The companion sairedis PRs are progressing (sonic-net/sonic-sairedis#1798 merged, sonic-net/sonic-sairedis#1935 open for review), and this CLI PR addresses all the feedback from the original #3001. CI was green when submitted. Would appreciate a review when you get a chance. Thanks!

Copilot

Pull request overview

This PR adds end-to-end CLI support in sonic-utilities for the Link Event Dampening feature by introducing new config, show, and sonic-clear commands, along with unit tests.

Changes:

Added config interface dampening <interface> enable|disable to configure AIED dampening parameters (including monitor-only mode) in CONFIG_DB.
Added show interfaces dampening [interface] to display dampening configuration plus operational state/counters.
Added sonic-clear interfaces dampening [interface] to request clearing (reset/unsuppress) of dampening state via STATE_DB, and added unit tests for the new CLIs.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
`config/main.py`	Adds `dampening` subgroup under `config interface` with `enable`/`disable` commands and parameter validation.
`show/interfaces/__init__.py`	Adds `show interfaces dampening` plus helper to print per-interface dampening counters.
`clear/main.py`	Adds `sonic-clear interfaces dampening` command that writes clear requests to STATE_DB.
`tests/link_event_damping_test.py`	Adds unit tests covering config/show/clear CLI behavior and validation scenarios.

+    if clicommon.get_interface_naming_mode() == "alias":
+        interface_name = interface_alias_to_name(config_db, interface_name)
+        if interface_name is None:
+            ctx.fail("'interface_name' is None!")
+


+    if clicommon.get_interface_naming_mode() == "alias":
+        interface_name = interface_alias_to_name(config_db, interface_name)
+        if interface_name is None:
+            ctx.fail("'interface_name' is None!")
+


+                click.echo("Error: invalid interface alias {}".format(alias))
+                sys.exit(1)
+        if interface_name not in port_table:
+            click.echo("Error: Interface {} does not exist".format(interface_name))
+            sys.exit(1)


+    state_db = SonicV2Connector(host="127.0.0.1")
+    state_db.connect(state_db.STATE_DB)
+


+    config_db = db.cfgdb
+    state_db = db.db
+


prsunny · 2026-06-09T16:34:54Z

@DendroLabs , could you check copilot comments and address them.

mssonicbld · 2026-06-09T18:11:37Z

/azp run

azure-pipelines · 2026-06-09T18:11:48Z

Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft · 2026-06-09T18:27:58Z

+    Without an interface name, clears dampening on all interfaces.
+    The interface is immediately unsuppressed if currently damped.
+    """
+    config_db = ConfigDBConnector()


host CONFIG_DB only — on multi-ASIC, PORT lives in per-namespace CONFIG_DB and that's where orchagent reads. Same issue with ctx.obj['config_db'] in the enable/disable commands. See how config interface ip add resolves the namespace via multi_asic.get_port_namespace(port) / db.cfgdb_clients[ns].

prsunny · 2026-06-19T17:20:52Z

@DendroLabs , could you address comment?

DendroLabs · 2026-06-19T22:39:56Z

Thanks @prsunny. Before I push the namespace fixes, I want to surface something I ran into while wiring the CLI against the now merged syncd implementation (#1906), because I think it is a design question worth settling together rather than me papering over it in the CLI.

What I am trying to do: make show/clear interfaces dampening work end to end as the operator facing front door for this feature, the same way operators already use show/clear for every other port level function.

Where the CLI and the merged syncd schema do not line up today:

STATE_DB key format. [port2alias]: Fix to get right number of return values #1906 writes the LINK_EVENT_DAMPING_STATS table keyed by the raw SAI port VID (oid:0x...). Every other operator facing STATE_DB port table (PORT_TABLE, transceiver, and so on) is keyed by port name (Ethernet0). Keying by VID means the CLI has to go through COUNTERS_PORT_NAME_MAP just to find a row, and anyone inspecting STATE_DB by hand cannot map entries back to ports. I would like to propose the stats table be keyed by port name for consistency and operator usability.
Manual clear. RFC 2439 section 4.8.6 calls out operator ability to manually clear damping, and Cisco and Juniper both expose it (clear interface dampening). The merged syncd does not yet have a handler for a clear request, so sonic-clear interfaces dampening has nothing to talk to. I would like to add that path so the clear command is real.
Monitor only mode. RFC 7196 recommends a dry run capability so operators can validate thresholds in production before any real suppression. My earlier work implemented this as an aied-monitor algorithm value (penalties and syslog computed, events not suppressed). The merged swss algorithm map only accepts disabled and aied, so there is currently no home for it. I think it is a meaningful safety feature and would like to find the right place for it.

Why it matters: without these, the CLI either reports N/A against a real switch (show), silently does nothing (clear), or rejects a documented mode (monitor). I would rather get the schema right than ship a front end that quietly does not match the back end.

That said, I am very happy to defer to you and @sivat6 on how to land this. If you would prefer I align the CLI to the existing VID keyed schema for now and treat the clear and monitor pieces as later follow ups, I am glad to do that and keep moving on the namespace fixes in parallel. If you would rather settle the schema first, I am happy to go whichever way fits best with how you see this feature evolving. Just let me know the direction you would like and I will follow it.

prsunny · 2026-06-20T01:42:31Z

@DendroLabs , my ask is to address copilot comments and from @qiluo-msft . not sure which one specifically you are referring to.

DendroLabs added 2 commits March 17, 2026 11:54

[Link Event Damping] Fix CLI critical issues

f484733

- Guard against exponential overflow in ceiling calculation - Add interface alias support to clear command - Improve error handling consistency Signed-off-by: DendroLabs <info@dendrolabs.com>

DendroLabs force-pushed the link-event-damping/cli branch from cf10a20 to f484733 Compare March 17, 2026 15:56

Fix flake8 style violations in dampening CLI

1895b3a

- Add missing blank line before dampening subgroup (E302) - Fix continuation line indentation in warning messages (E127) Signed-off-by: DendroLabs <info@dendrolabs.com>

Remove unused imports in dampening test file

6eaf7a0

Signed-off-by: DendroLabs <info@dendrolabs.com>

This was referenced Mar 29, 2026

[Link Event Damping] Add per port link event damper class. sonic-net/sonic-sairedis#1334

Open

Add libsai RedisInterface for link event damping. sonic-net/sonic-sairedis#1331

Closed

prsunny mentioned this pull request May 22, 2026

Add link event damping support #4563

Open

This was referenced Jun 9, 2026

[Link Event Damping] Add RedisInterface plumbing for damping config sonic-net/sonic-sairedis#1935

Closed

Link event damping feature sonic-net/sonic-sairedis#1906

Merged

prsunny requested a review from Copilot June 9, 2026 16:28

Copilot started reviewing on behalf of prsunny June 9, 2026 16:28 View session

prsunny enabled auto-merge (squash) June 9, 2026 16:29

prsunny approved these changes Jun 9, 2026

View reviewed changes

Copilot AI reviewed Jun 9, 2026

View reviewed changes

qiluo-msft closed this Jun 9, 2026

auto-merge was automatically disabled June 9, 2026 18:11
Pull request was closed

qiluo-msft reopened this Jun 9, 2026

qiluo-msft reviewed Jun 9, 2026

View reviewed changes

DendroLabs mentioned this pull request Jun 20, 2026

[Link Event Damping] Add per-port link event damper with syslog and monitor-only mode sonic-net/sonic-sairedis#1936

Closed

		state_db = SonicV2Connector(host="127.0.0.1")
		state_db.connect(state_db.STATE_DB)

Uh oh!

Conversation

DendroLabs commented Mar 17, 2026

Summary

Test plan

Uh oh!

mssonicbld commented Mar 17, 2026

Uh oh!

linux-foundation-easycla Bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines Bot commented Mar 17, 2026

Uh oh!

mssonicbld commented Mar 17, 2026

Uh oh!

azure-pipelines Bot commented Mar 17, 2026

Uh oh!

DendroLabs commented Mar 17, 2026

Uh oh!

mssonicbld commented Mar 17, 2026

Uh oh!

azure-pipelines Bot commented Mar 17, 2026

Uh oh!

mssonicbld commented Mar 17, 2026

Uh oh!

azure-pipelines Bot commented Mar 17, 2026

Uh oh!

mssonicbld commented Mar 17, 2026

Uh oh!

azure-pipelines Bot commented Mar 17, 2026

Uh oh!

DendroLabs commented Jun 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

prsunny commented Jun 9, 2026

Uh oh!

mssonicbld commented Jun 9, 2026

Uh oh!

azure-pipelines Bot commented Jun 9, 2026

Uh oh!

qiluo-msft Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

prsunny commented Jun 19, 2026

Uh oh!

DendroLabs commented Jun 19, 2026

Uh oh!

prsunny commented Jun 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

linux-foundation-easycla Bot commented Mar 17, 2026 •

edited

Loading