Add link event damping support by sivat6 · Pull Request #4563 · sonic-net/sonic-utilities

sivat6 · 2026-05-22T10:58:40Z

This PR is merging the changes done in #3001.

What I did

Added new config cli for link event damping
Added the test code for the same
Update the doc/Command-Referrence.md with the description of new CLIs.

How I did it
Added 'damping' group in interface and added sub-commands 'algo' and 'aied-param' under damping group.
'algo' has 2 options - aied, disabled
'aied-param' has 5 configs - max-suppress-time, decay-half-life, suppress-threshold, reuse-threshold, flap-penalty

aied-param config params can be configured by executing one or more params.

Example config CLI:
sudo config interface damping algo Ethernet0 aied
sudo config interface damping aied-param Ethernet0 --suppress-threshold 1400 --decay-half-life 20000 --max-suppress-time 40000 --flap-penalty 1000 --reuse-threshold 1100

Here is the CLI syntax:

$ sudo config interface
Usage: config interface [OPTIONS] COMMAND [ARGS]...

Interface-related configuration tasks

Options:
-n, --namespace [] Namespace name
-?, -h, --help Show this message and exit.

Commands:
advertised-speeds Set interface advertised speeds
advertised-types Set interface advertised types
autoneg Set interface auto negotiation mode
breakout Set interface breakout mode

$ sudo config interface damping
Usage: config interface damping [OPTIONS] COMMAND [ARGS]...

Set interface damping configurations

Options:
-?, -h, --help Show this message and exit.

Commands:
aied-param Set AIED link event damping configuration
algo Set link event damping algorithm

$ sudo config interface damping algo Ethernet0
Usage: config interface damping algo [OPTIONS] <interface_name> <algo_type>
Try 'config interface damping algo -h' for help.

Error: Missing argument '<algo_type>'. Choose from:
aied,
disabled

$ sudo config interface damping aied-param Ethernet0 --help
Usage: config interface damping aied-param [OPTIONS] <interface_name>

Set AIED link event damping configuration

Options:
--max-suppress-time INTEGER Set max suppress time in ms
--decay-half-life INTEGER Set decay half life in ms
--suppress-threshold INTEGER Set suppress threshold
--reuse-threshold INTEGER Set reuse threshold
--flap-penalty INTEGER Set flap penalty
-h, -?, --help Show this message and exit.
admin@shifu-garnet01:~$

How to verify it
Unit Testing:
Complete UT was carried out for the link event damping feature (53 test cases and UT logs available)

mssonicbld · 2026-05-22T10:58:48Z

/azp run

azure-pipelines · 2026-05-22T10:58:59Z

Azure Pipelines successfully started running 1 pipeline(s).

prsunny · 2026-05-22T19:07:31Z

Changes lgtm, Can you please update description per template?

prsunny · 2026-05-22T19:09:28Z

Please check this PR and check anything pending - #4367

sivat6 · 2026-05-26T10:43:25Z

Please check this PR and check anything pending - #4367

Yes, changes are missing from this PR 4367. Added the missing changes.

mssonicbld · 2026-05-27T05:01:33Z

/azp run

azure-pipelines · 2026-05-27T05:01:43Z

Azure Pipelines successfully started running 1 pipeline(s).

sivat6 · 2026-05-27T05:08:17Z

Please check this PR and check anything pending - #4367

This PR is not listed in the HLD. Anyway thanks for pointing out. Added all missing code from PR# 4357.

prsunny · 2026-05-28T00:10:07Z

Please fix build issues

mssonicbld · 2026-05-28T05:11:09Z

/azp run

azure-pipelines · 2026-05-28T05:11:21Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-05-28T06:23:15Z

/azp run

azure-pipelines · 2026-05-28T06:23:27Z

Azure Pipelines successfully started running 1 pipeline(s).

prsunny · 2026-06-01T19:25:46Z

Changes lgtm, Can you please update description per template?

Please address this comment and also fix build issue

mssonicbld · 2026-06-03T09:17:42Z

/azp run

azure-pipelines · 2026-06-03T09:17:55Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-06-03T10:08:00Z

/azp run

azure-pipelines · 2026-06-03T10:08:12Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-06-03T10:14:18Z

/azp run

azure-pipelines · 2026-06-03T10:14:31Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-06-03T11:18:41Z

/azp run

azure-pipelines · 2026-06-03T11:18:52Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-06-03T11:52:11Z

/azp run

azure-pipelines · 2026-06-03T11:52:22Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-06-03T11:53:09Z

/azp run

azure-pipelines · 2026-06-03T11:53:20Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2026-06-03T13:00:33Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-06-03T14:11:15Z

/azp run

azure-pipelines · 2026-06-03T14:11:28Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-06-04T04:44:18Z

/azp run

azure-pipelines · 2026-06-04T04:44:29Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-06-04T06:44:56Z

/azp run

azure-pipelines · 2026-06-04T06:45:08Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-06-04T06:47:34Z

/azp run

azure-pipelines · 2026-06-04T06:47:45Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Sivakumar Thirukkanna Thevar <sthirukkanna@juniper.net>

mssonicbld · 2026-06-04T07:40:29Z

/azp run

azure-pipelines · 2026-06-04T07:40:40Z

Azure Pipelines successfully started running 1 pipeline(s).

prsunny · 2026-06-04T16:10:59Z

Changes lgtm, Can you please update description per template?

Please address this. We need the details of new CLI.

sivat6 · 2026-06-08T09:49:37Z

Changes lgtm, Can you please update description per template?

Please address this. We need the details of new CLI.

Added the CLI details. Please let me know if this is ok.

prsunny · 2026-06-08T21:24:20Z

Please check this PR and check anything pending - #4367

This PR is not listed in the HLD. Anyway thanks for pointing out. Added all missing code from PR# 4357.

How about 'show' command?

Copilot

Pull request overview

This PR adds CLI support in config interface for configuring link event damping (algorithm selection and AIED parameters), along with new unit tests and corresponding Command Reference documentation updates.

Changes:

Add config interface damping command group with algo and aied-param subcommands writing to CONFIG_DB PORT entries.
Add unit tests covering valid/invalid damping algorithm selection and AIED parameter validation.
Document the new CLI syntax and examples in doc/Command-Reference.md.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
`config/main.py`	Adds the new `config interface damping` CLI commands and validation logic.
`tests/link_event_damping_test.py`	Adds direct CLI-invocation tests for damping algorithm and AIED params.
`tests/config_int_damping_test.py`	Adds a basic test suite for damping commands similar to other `config interface` tests.
`doc/Command-Reference.md`	Documents the new damping CLI commands, usage, and examples.

+    if reuse_threshold is not None and suppress_threshold is not None:
+        if reuse_threshold >= suppress_threshold:
+            ctx.fail(
+                "Invalid configuration: reuse_threshold ({}) must be less than suppress_threshold ({})"
+                .format(reuse_threshold, suppress_threshold)
+            )
+
+    if decay_half_life is not None and max_suppress_time is not None:
+        if decay_half_life > max_suppress_time:
+            ctx.fail(
+                "Invalid configuration: decay_half_life ({}) must be <= max_suppress_time ({})"
+                .format(decay_half_life, max_suppress_time)
+            )


+    @classmethod
+    def setup_class(cls):
+        print("SETUP")
+        os.environ["UTILITIES_UNIT_TESTING"] = "1"
+


+    config interface damping algo Ethernet20 disabled
+    ```
+
+***config interface damping aied-param (Versions >= 202311***


sivat6 force-pushed the link_event_damping_feature branch from 92ba5fe to 8879ee2 Compare May 28, 2026 05:11

sivat6 force-pushed the link_event_damping_feature branch from 255b3df to 3c1cca5 Compare June 3, 2026 10:14

sivat6 force-pushed the link_event_damping_feature branch from 3d80b67 to 533ee52 Compare June 3, 2026 11:18

sivat6 force-pushed the link_event_damping_feature branch from 56d068d to d0688ff Compare June 3, 2026 11:53

sivat6 force-pushed the link_event_damping_feature branch from f7b2694 to ced3ee2 Compare June 4, 2026 04:44

sivat6 added 11 commits June 4, 2026 13:09

Add link event damping support

0b35ebf

Signed-off-by: Sivakumar Thirukkanna Thevar <sthirukkanna@juniper.net>

Addressing code review comments

47c3529

Signed-off-by: Sivakumar Thirukkanna Thevar <sthirukkanna@juniper.net>

Fix build errors

eaf92bb

Signed-off-by: Sivakumar Thirukkanna Thevar <sthirukkanna@juniper.net>

Fixing flake8 errors

25a114e

Signed-off-by: Sivakumar Thirukkanna Thevar <sthirukkanna@juniper.net>

Fixing indentation issue

2ae5a3d

Signed-off-by: Sivakumar Thirukkanna Thevar <sthirukkanna@juniper.net>

Modified the link_event_damping_test.py to suite with damping CLIs

177b024

Signed-off-by: Sivakumar Thirukkanna Thevar <sthirukkanna@juniper.net>

Fixing indentation issue in link_event_damping_test.py

1c04667

Signed-off-by: Sivakumar Thirukkanna Thevar <sthirukkanna@juniper.net>

Adding checks for damping config params

413ad22

Signed-off-by: Sivakumar Thirukkanna Thevar <sthirukkanna@juniper.net>

Fixed invalid config params and extra blank lines

993034a

Signed-off-by: Sivakumar Thirukkanna Thevar <sthirukkanna@juniper.net>

Removing show & clear CLI related code

74dc6a4

Signed-off-by: Sivakumar Thirukkanna Thevar <sthirukkanna@juniper.net>

Removing the missed line in clear.py

30e05da

Signed-off-by: Sivakumar Thirukkanna Thevar <sthirukkanna@juniper.net>

sivat6 force-pushed the link_event_damping_feature branch from 38adf57 to 30e05da Compare June 4, 2026 07:40

prsunny requested a review from Copilot June 8, 2026 21:24

Copilot started reviewing on behalf of prsunny June 8, 2026 21:24 View session

Copilot AI reviewed Jun 8, 2026

View reviewed changes

Uh oh!

Conversation

sivat6 commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mssonicbld commented May 22, 2026

Uh oh!

azure-pipelines Bot commented May 22, 2026

Uh oh!

prsunny commented May 22, 2026

Uh oh!

prsunny commented May 22, 2026

Uh oh!

sivat6 commented May 26, 2026

Uh oh!

mssonicbld commented May 27, 2026

Uh oh!

azure-pipelines Bot commented May 27, 2026

Uh oh!

sivat6 commented May 27, 2026

Uh oh!

prsunny commented May 28, 2026

Uh oh!

mssonicbld commented May 28, 2026

Uh oh!

azure-pipelines Bot commented May 28, 2026

Uh oh!

mssonicbld commented May 28, 2026

Uh oh!

azure-pipelines Bot commented May 28, 2026

Uh oh!

prsunny commented Jun 1, 2026

Uh oh!

mssonicbld commented Jun 3, 2026

Uh oh!

azure-pipelines Bot commented Jun 3, 2026

Uh oh!

mssonicbld commented Jun 3, 2026

Uh oh!

azure-pipelines Bot commented Jun 3, 2026

Uh oh!

mssonicbld commented Jun 3, 2026

Uh oh!

azure-pipelines Bot commented Jun 3, 2026

Uh oh!

mssonicbld commented Jun 3, 2026

Uh oh!

azure-pipelines Bot commented Jun 3, 2026

Uh oh!

mssonicbld commented Jun 3, 2026

Uh oh!

azure-pipelines Bot commented Jun 3, 2026

Uh oh!

mssonicbld commented Jun 3, 2026

Uh oh!

azure-pipelines Bot commented Jun 3, 2026

Uh oh!

azure-pipelines Bot commented Jun 3, 2026

Uh oh!

mssonicbld commented Jun 3, 2026

Uh oh!

azure-pipelines Bot commented Jun 3, 2026

Uh oh!

mssonicbld commented Jun 4, 2026

Uh oh!

azure-pipelines Bot commented Jun 4, 2026

Uh oh!

mssonicbld commented Jun 4, 2026

Uh oh!

azure-pipelines Bot commented Jun 4, 2026

Uh oh!

mssonicbld commented Jun 4, 2026

Uh oh!

azure-pipelines Bot commented Jun 4, 2026

Uh oh!

mssonicbld commented Jun 4, 2026

Uh oh!

azure-pipelines Bot commented Jun 4, 2026

Uh oh!

prsunny commented Jun 4, 2026

sivat6 commented May 22, 2026 •

edited

Loading