stpmgr: Unify IPC with sonic-stp and replace ebtables with nftables - #4790
Open
rdhegde wants to merge 7 commits into
Open
stpmgr: Unify IPC with sonic-stp and replace ebtables with nftables#4790rdhegde wants to merge 7 commits into
rdhegde wants to merge 7 commits into
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
The STP IPC structures exchanged between stpmgr-daemon and stp-daemon were duplicated. Once defined in sonic-swss/cfgmgr/stpmgr.h and again in sonic-stp/include/stp_ipc.h. The definition in the first file has been removed and stp_ipc.h is included in stpmgr.h Signed-off-by: Ram Hegde <rhegde@marvell.com>
In sendMsgStpd(), STP_IPC_MSG message is created and sent to the STP daemon. Here "proto_mode" in the IPC message is not populated. Due to this the message in STP daemon is ignored since the proto_mode check fails. Signed-off-by: Ram Hegde <rhegde@marvell.com>
* In doVlanMemUpdateTask(), prevented reinitlization of priority and path_cost of STP_VLAN_MEM_CONFIG_MSG message instance * In doTask() prevented duplicate call to doStpPortTask() * In doStpMstInstTask(), moved call to updateVlanInstanceMap() outside the for-loop which fetches the attributes. Signed-off-by: Ram Hegde <rhegde@marvell.com>
on completion instead of failure ( -1 ). Signed-off-by: Ram Hegde <rhegde@marvell.com>
ebtables filtering is not supported in kernel so replace the same with nft. Signed-off-by: Ram Hegde <rhegde@marvell.com>
* cfgmgr/stpmgr.cpp * cfgmgr/stpmgrd.cpp Which involved using the proper debug level and format specifier Removed the macro STPD_SOCK_NAME from cfgmgr/stpmgr.h as it is already defined in stp_ipc.h Signed-off-by: Ram Hegde <rhegde@marvell.com>
rdhegde
force-pushed
the
rdhegde-pvst-swss
branch
from
July 25, 2026 14:01
6ed47ed to
4371ebf
Compare
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
rdhegde
changed the title
Signed-off-by: Ram Hegde <rhegde@marvell.com>
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stp_ipc.hin STPMGR; remove duplicatestructures from
stpmgr.h.kernel for required STP functionality).
Motivation
PVST configuration fails when STPMGR uses IPC layouts that don’t match the STP
daemon, or when packet filtering still relies on ebtables. This PR aligns
STPMGR with the sonic-stp IPC changes and updates filtering to nftables.
Part of PVST fix series for #28624.
Changes
stp_ipc.hinstpmgr.hRelated PRs
Verification
sonic-vs): config reached STP daemon, PVSTconverged