stp: Fix IPC layout and netlink handling between STPMGR and STP daemon - #97
Open
rdhegde wants to merge 6 commits into
Open
stp: Fix IPC layout and netlink handling between STPMGR and STP daemon#97rdhegde wants to merge 6 commits into
rdhegde wants to merge 6 commits into
Conversation
- Packed stp IPC structures - Added missing parameter `loop_guard` to align with swss(stpmgr) - Renamed parameters: `edge` and `max_hop` to align with swss(stpmgr) - Renamed MST_INST_CONFIG_MSG to STP_MST_INST_CONFIG_MSG for consistency Signed-off-by: Ram Hegde <rhegde@marvell.com>
- fix socket return handling - remove unused variable Signed-off-by: Ram Hegde <rhegde@marvell.com>
Signed-off-by: Ram Hegde <rhegde@marvell.com>
- uninitialized if_db.ifname is not handled before calling stp_netlink_cb() Signed-off-by: Ram Hegde <rhegde@marvell.com>
Signed-off-by: Ram Hegde <rhegde@marvell.com>
Collaborator
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Author
|
/easycla |
* In stpmgr_process_rx_bpdu(), when PVST BPDUs has no VLAN get the port's untagged VLAN * Fixed typos in code comments Signed-off-by: Ram Hegde <rhegde@marvell.com>
rdhegde
force-pushed
the
rdhegde-pvst-stp
branch
from
July 25, 2026 13:55
1aa8c23 to
334e762
Compare
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
rdhegde
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
single, packed definition with all required fields.
unexpected protocol modes.
stp_netlink_recv()passing an invalidif_db/ ifname intostp_netlink_cb().Motivation
PVST configuration fails when STPMGR and the STP daemon exchange
inconsistent or incomplete IPC data, or when netlink callbacks operate on
invalid interface state. This PR fixes the daemon-side IPC and netlink
handling required for PVST to work reliably.
Part of PVST fix series for #28624.
Changes
stp_intf_netlink_cb()stpmgr_process_ipc_msg()for unexpected protocol modesstp_netlink_recv()callingstp_netlink_cb()with invalidif_db/ ifnameRelated PRs
Verification
sonic-vs): config reached STP daemon,PVST converged
Notes for reviewers
with sonic-swss#4790