[swss]: BFD hardware offload for BGP sessions - #3267
Open
baorliu wants to merge 393 commits into
Open
Conversation
siqbal1986
self-requested a review
September 3, 2024 03:34
Contributor
|
can you please make sure that the build is passing. Also can you add soem swss tests to verify functionality |
baorliu
changed the title
baorliu
marked this pull request as draft
November 4, 2024 23:19
Contributor
Author
|
convert it to draft due to some planned update |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
baorliu
marked this pull request as ready for review
February 25, 2025 22:23
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
added mock test. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
mock test was added. The feature is in some production image and no build issue. will monitor pipeline build issue here. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…et#3440) What I did: - Updated stpmgr.h to replace packed structs with aligned structs - Replaced the old processStpPortAttr in stpmgr.cpp with a version that uses properly aligned STP_PORT_CONFIG_MSG allocations How I did it: - Applied the same alignment fixes from 202211 branch to master - Removed #pragma GCC diagnostic usage and introduced ALIGNED(4) as well as padding fields in the relevant STP_* structures Why I did it: - To resolve address-of-packed-member warnings that break builds with certain compiler/platform configurations (e.g., Broadcom) - Aligning data structures properly avoids potential misalignment errors Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
…ries. Signed-off-by: mint570 <runmingwu@google.com> Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
What I did Remove deprecated parameters. Why I did it The parameter, print_to_console, has been removed, but the CI will not run any bench program, so this error was ignored. Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
…n table entries. Signed-off-by: mint570 <runmingwu@google.com> Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com> Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
What I did Added support for polling PORT PHY attributes using the flex counter infrastructure. Following changes are added in swss to support this feature define a new counter type PORT_PHY_ATTR support added for polling following attributes, SAI_PORT_ATTR_RX_SIGNAL_DETECT, SAI_PORT_ATTR_FEC_ALIGNMENT_LOCK, SAI_PORT_ATTR_RX_SNR Add port_phy_attr_manager to set counter id list in FLEX_COUNTERS_DB Added unit tests to validate the enable/disable code flow, generatePortAttrCounterMap and QueryPortAttrCapabilitiesWithMockedSAI. Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
…s is Inband port (sonic-net#4157) What I did Fixed the bug reported in sonic-net/sonic-buildimage#25211 Fixed the bug introduced in sonic-net#4054 which was preventing the ever flow mirror sessions becoming active in remote Asics. When the nexthop is added in remote asics in Voq systems, it is always added against the Inband port and not on the remote system port. So when the nexthop is resolved for the mirror session in the remote asic, the mirror code calls getNeighborEntry to find the nexthop entry by passing the nexthop of the route entry for the mirror destination. Since the nexthop was added on Inband port and getNeighborEntry was checking for RemoteSystemPort, finding nexthop was failing and hence the mirror session never gets activated in remote asics. So modified the code to include the isInbandPort check in addition to isRemoteSystemPortIntf . The isRemoteSystemPortIntf might be needed since the neighbor entries are added against the remote system port. Why I did it Fixed the bug introduced in sonic-net#4054 which prevents the ever flow mirror sessions becoming active in remote Asics. When the nexthop is added in remote asics in Voq systems, it is always added against the Inband port and not on the remote system port. So when the nexthop is resolved for the mirror session in the remote asic, the mirror code calls getNeighborEntry to find the nexthop entry by passing the nexthop of the route entry for the mirror destination. Since the nexthop was added on Inband port and getNeighborEntry was checking for RemoteSystemPort, finding nexthop was failing and hence the mirror session never gets activated in remote asics. So modified the code to include the isInbandPort check in addition to isRemoteSystemPortIntf . The isRemoteSystemPortIntf might be needed since the neighbor entries are added against the remote system port. Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
…cast. Signed-off-by: mint570 <runmingwu@google.com> Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
What I did Support route update from vnet tunnel route config change for custom_bfd monitoring. In DPU repairing scenario (to form HA sets), VNetOrch needs to support live update of endpoints, monitoring endpoints, primary and secondary groups. sign-off: Jing Zhang zhangjing@microsoft.com Why I did it This change is required for DPU repair in HA. How I did it When there is a route config change (i.e. primary endpoint changes), pass a BFD state update with Init state to trigger the monitoring session creation & deletion, and route update. Notice that monitoring orch will pass Down and Up state to vnet orch. Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
* [ci] Install pytest and redis from Debian For the CI runner, install the python3 pytest and redis packages from the Debian repos instead of via pip. This has the advantage of the version being fixed for the Debian version the test runner is using. This works around the regression for Unix sockets introduced in redis 7.2.0 (see also redis/redis-py#3957 and redis/redis-py#3957). Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
baorliu
force-pushed
the
baorliu_bgp_bfd
branch
from
February 23, 2026 20:33
69d512b to
a0a4615
Compare
baorliu
requested review from
abdosi,
bingwang-ms and
judyjoseph
as code owners
February 23, 2026 20:33
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
baorliu
force-pushed
the
baorliu_bgp_bfd
branch
from
February 23, 2026 20:45
a0a4615 to
0f7124b
Compare
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
baorliu
force-pushed
the
baorliu_bgp_bfd
branch
from
February 23, 2026 20:46
0f7124b to
cb83acb
Compare
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
baorliu
force-pushed
the
baorliu_bgp_bfd
branch
from
February 23, 2026 20:49
cb83acb to
42c0b3e
Compare
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Contributor
Author
|
messed up the PR by trying to solve DCO error ... trying to recover this PR now followed this instruction to solve DCO error, and the branch get messed up: |
Contributor
Author
mock tests added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Notes] some other commits and files were pushed into this branch by mistake when trying to fix a DCO error, this PR is under repair. for design changes, please refer to the following PR before this one is fixed;
#4253
What I did
using hardware offloaded BFD to replace frr/bfdd for BGP neighbor reachability detection.
Why I did it
Hardware offloaded BFD usually provide more bfd sessions support, and has shorter detection time comparing to software bfd. and also lower CPU load because that BFD sessions are offloaded to hardware/ASIC.
How I verified it
The design was built into a sonic image, and verified in a hardware testbed.
Details if related
This program is built under sonic-swss, but running in bgp container.
HLD in PR review:
sonic-net/SONiC#1599
[notes] some commit history are lost after a force push after fixing a DCO error.
git log before the force push: