[bfd] BFD HW offload for BGP sessions - #1599
Conversation
Initial version, a proposal for BFD hardware offload for BGP sessions
|
@baorliu , please follow the template for the description and list all associated PRs. Will assign the reviewers |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
@kperumalbfn @abdosi @siqbal1986 Appreciate if you can review the PR again. |
| @@ -0,0 +1,612 @@ | |||
| # BFD HW Offload for BGP session | |||
There was a problem hiding this comment.
We have added a temporary Section 2.1.1 in the HLD (#2225), which outlines the differences between the current HLD and the newly proposed HLD.
The proposed HLD is comprehensive and covers all the features required in the field. Please note that the sections related to sBFD for SRv6 are still being updated.
That said, it would be beneficial to align on a single, comprehensive HLD and implement it through a series of smaller PRs that can be distributed among various stakeholders. Your PR (sonic-net/sonic-swss#4253) is an ideal starting point and can serve as the foundation for subsequent changes.
Looking forward to your response.
|
Can you share/link the sonic-mgmt tests for this feature |
Signed-off-by: Baorong Liu <baorliu@cisco.com>
|
/azp run |
|
No pipelines are associated with this pull request. |
Signed-off-by: Baorong Liu <baorliu@cisco.com>
|
/azp run |
|
No pipelines are associated with this pull request. |
Signed-off-by: Baorong Liu <baorliu@cisco.com>
|
/azp run |
|
No pipelines are associated with this pull request. |
Signed-off-by: Baorong Liu <baorliu@cisco.com>
|
/azp run |
|
No pipelines are associated with this pull request. |
Signed-off-by: Baorong Liu <baorliu@cisco.com>
|
/azp run |
|
No pipelines are associated with this pull request. |
prsunny
left a comment
There was a problem hiding this comment.
Testplan can be extended for more scenario but can be added later. approving
|
@rajshekhar-nexthop , would you signoff? |
Sure. LGTM. We will rename and rework HLD #2225 as “BFD Syncd Enhancements” and use the current HLD #1599 as the foundation for BFD Syncd. Thanks. |
BGP can be configured to use BFD to monitor it's neighbor reachability. when the BFD session becomes DOWN, it indicates that BGP neighbor become not reachable, so BGP can updates the corresponding route quickly based on BFD state, the detection can be much faster than the detection using BGP keep alive approach.
Currently, BGP can use frr/bfdd (a software BFD) to do this.
The proposed design let BGP use hardware offloaded BFD in SONiC, it provide a faster detection, less CPU load, and supports more BGP sessions to use BFD.