Skip to content

[bfd] BFD HW offload for BGP sessions - #1599

Merged
prsunny merged 14 commits into
sonic-net:masterfrom
baorliu:bgp_bfd_hw_offload_baorliu
Apr 28, 2026
Merged

[bfd] BFD HW offload for BGP sessions#1599
prsunny merged 14 commits into
sonic-net:masterfrom
baorliu:bgp_bfd_hw_offload_baorliu

Conversation

@baorliu

@baorliu baorliu commented Feb 4, 2024

Copy link
Copy Markdown
Contributor

BGP can be configured to use BFD to monitor it's neighbor reachability. when the BFD session becomes DOWN, it indicates that BGP neighbor become not reachable, so BGP can updates the corresponding route quickly based on BFD state, the detection can be much faster than the detection using BGP keep alive approach.
Currently, BGP can use frr/bfdd (a software BFD) to do this.
The proposed design let BGP use hardware offloaded BFD in SONiC, it provide a faster detection, less CPU load, and supports more BGP sessions to use BFD.

Repo PR title State
sonic-swss[master] BFD hardware offload for BGP sessions  GitHub issue/pull request detail

@prsunny

prsunny commented Sep 13, 2024

Copy link
Copy Markdown
Contributor

@baorliu , please follow the template for the description and list all associated PRs. Will assign the reviewers

Comment thread doc/bfd/BFD HW Offload for BGP session HLD.md
Comment thread doc/bfd/BFD HW Offload for BGP session HLD.md
Comment thread doc/bfd/BFD HW Offload for BGP session HLD.md
Comment thread doc/bfd/BFD HW Offload for BGP session HLD.md
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@ashutosh-agrawal

Copy link
Copy Markdown
Member

@kperumalbfn @abdosi @siqbal1986 Appreciate if you can review the PR again.

@baorliu baorliu mentioned this pull request Feb 25, 2026
Comment thread doc/bfd/BFD HW Offload for BGP session HLD.md
@@ -0,0 +1,612 @@
# BFD HW Offload for BGP session

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have added a temporary Section 2.1.1 in the HLD (#2225), which outlines the differences between the current HLD and the newly proposed HLD.

The proposed HLD is comprehensive and covers all the features required in the field. Please note that the sections related to sBFD for SRv6 are still being updated.

That said, it would be beneficial to align on a single, comprehensive HLD and implement it through a series of smaller PRs that can be distributed among various stakeholders. Your PR (sonic-net/sonic-swss#4253) is an ideal starting point and can serve as the foundation for subsequent changes.

Looking forward to your response.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested by @pbrisset, we will rename HLD #2225 to “BFD Syncd Enhancements” and use current HLD #1599 as the foundation for BFD Syncd. Thanks

Comment thread doc/bfd/BFD HW Offload for BGP session HLD.md Outdated
@prsunny

prsunny commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Can you share/link the sonic-mgmt tests for this feature

Signed-off-by: Baorong Liu <baorliu@cisco.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@prsunny
prsunny requested a review from dgsudharsan April 17, 2026 03:35
Comment thread doc/bfd/BFD HW Offload for BGP session HLD.md Outdated
Signed-off-by: Baorong Liu <baorliu@cisco.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

Comment thread doc/bfd/BFD HW Offload for BGP session HLD.md Outdated
Comment thread doc/bfd/BFD HW Offload for BGP session HLD.md Outdated
Comment thread doc/bfd/BFD HW Offload for BGP session HLD.md Outdated
Signed-off-by: Baorong Liu <baorliu@cisco.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

Comment thread doc/bfd/BFD HW Offload for BGP session HLD.md Outdated
Signed-off-by: Baorong Liu <baorliu@cisco.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

Signed-off-by: Baorong Liu <baorliu@cisco.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@prsunny prsunny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testplan can be extended for more scenario but can be added later. approving

@prsunny

prsunny commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

@rajshekhar-nexthop , would you signoff?

@rajshekhar-nexthop

Copy link
Copy Markdown
Contributor

@rajshekhar-nexthop , would you signoff?

Sure. LGTM. We will rename and rework HLD #2225 as “BFD Syncd Enhancements” and use the current HLD #1599 as the foundation for BFD Syncd. Thanks.

@prsunny
prsunny merged commit 119cca3 into sonic-net:master Apr 28, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in SONiC 202605 Release Apr 28, 2026
@delnas delnas moved this from Done to In Progress in SONiC 202605 Release May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress
Status: No status

Development

Successfully merging this pull request may close these issues.