tests/platform_tests/api/test_thermal_leak_sensor.py fixes - #26086
Merged
Conversation
max_minor_duration_sec allow 0 and added the assertion fixture Signed-off-by: nmirin <nikolay.a.mirin@gmail.com>
Collaborator
|
/azp run |
github-actions
Bot
requested review from
rawal01,
xwjiang-ms and
yutongzhang-microsoft
July 11, 2026 03:36
|
Azure Pipelines successfully started running 1 pipeline(s). |
judyjoseph
approved these changes
Jul 14, 2026
Contributor
|
@yejianquan could you help merge this thx |
Contributor
Author
|
@yxieca @yejianquan would you please help to merge? |
Contributor
Author
|
@abdosi would you please also see if you can merge this one? |
Collaborator
|
This PR has backport request label(s) for branch(es): msft-202608, but is missing required test information. Please make sure you tick the tested branch(es) in the Tested branch section and provide test evidence (e.g., 202608: <test result>) in the Test result section as well in your PR description. ---Powered by SONiC BuildBot
|
Contributor
|
LGTM |
12 tasks
Collaborator
|
Cherry-pick PR to msft-202608: Azure/sonic-mgmt.msft#1351 |
mssonicbld
added
Included in msft-202608 branch
and removed
Created PR to msft-202608 branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
max_minor_duration_sec allow 0 and added the assertion fixture
Description of PR
This PR adds the assertion fixture to be autoused in the tests and call the base class code
Also it allows max_minor_duration_sec to be 0, per tests design.
Fixes: #26226
Summary:
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix the test bugs
How did you do it?
Added the assertion fixture similar to other subclasses
How did you verify/test it?
Ran the test, and it failed with max_minor_duration_sec == 0 since the assertion was made that time correctly.
Fixed the test to allow max_minor_duration_sec == 0
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation