[action] [PR:26086] tests/platform_tests/api/test_thermal_leak_sensor.py fixes - #1351
Merged
Merged
Conversation
max_minor_duration_sec allow 0 and added the assertion fixture ### Description of PR This PR adds the assertion fixture to be autoused in the tests and call the base class code Also it allows max_minor_duration_sec to be 0, per tests design. Fixes: sonic-net/sonic-mgmt#26226 Summary: ### Type of change - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [ ] 202511 - [ ] 202512 - [ ] 202605 ### Approach #### What is the motivation for this PR? Fix the test bugs #### How did you do it? Added the assertion fixture similar to other subclasses #### How did you verify/test it? Ran the test, and it failed with max_minor_duration_sec == 0 since the assertion was made that time correctly. Fixed the test to allow max_minor_duration_sec == 0 Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com> #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation
Collaborator
Author
|
Original PR: sonic-net/sonic-mgmt#26086 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
12 tasks
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
max_minor_duration_sec allow 0 and added the assertion fixture
Description of PR
This PR adds the assertion fixture to be autoused in the tests and call the base class code
Also it allows max_minor_duration_sec to be 0, per tests design.
Fixes: sonic-net/sonic-mgmt#26226
Summary:
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix the test bugs
How did you do it?
Added the assertion fixture similar to other subclasses
How did you verify/test it?
Ran the test, and it failed with max_minor_duration_sec == 0 since the assertion was made that time correctly.
Fixed the test to allow max_minor_duration_sec == 0
Signed-off-by: Sonic Build Admin sonicbld@microsoft.com
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation