Add support for deriving Solana root account (m/44'/501') in Seed Vault - #636
Open
joaopeixoto13 wants to merge 1 commit into
Open
Add support for deriving Solana root account (m/44'/501') in Seed Vault#636joaopeixoto13 wants to merge 1 commit into
joaopeixoto13 wants to merge 1 commit into
Conversation
This commit extends Solana account discovery by deriving and registering the root-level BIP44 account at path m/44'/501'. Previously, only indexed accounts (m/44'/501'/X' and m/44'/501'/X'/0') were discovered. Changes: - Added root derivation path construction using BIP44 purpose and coin type. - Derived root public key using full partial-derivation. - Added root account insertion into knownAccounts if not already stored. - Preserved existing logic for Type-1 and Type-2 accounts. - Improved log messages for clarity and consistency. This enables compatibility with wallets that treat the base path m/44'/501' as a valid Solana address. Signed-off-by: João Peixoto <joaopeixotooficial@gmail.com>
Contributor
|
Hi João, thanks for opening a pull request for this. I wanted to clarify one thing - the function you are modifying is only the default set of derived accounts, not the allowed set of accounts. There are 2 real implementations of Seed Vault in the wild; Saga and Seeker. Both of these derive the default set of accounts according to the current logic: I'd request that you move this to a GitHub issue first, so we can discuss this change further. For example, I'm curious which wallet app consumers of the Seed Vault API would want to have this derivation path as part of the default set? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends Solana account discovery by deriving and registering the root-level BIP44 account at path
m/44'/501'. Previously, only indexed accounts (m/44'/501'/X' andm/44'/501'/X'/0') were discovered.Changes:
This enables compatibility with wallets that treat the base path
m/44'/501'as a valid Solana address (e.g., Ledger).