-
Notifications
You must be signed in to change notification settings - Fork 3
chore: add logs for bundle uploads and in-flight modification detection #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mihaibuzgau
wants to merge
1
commit into
main
Choose a base branch
from
chore/CLI-1364_add_bundle_debug
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -214,15 +214,40 @@ func (b *bundleManager) Upload( | |
| return bundle, nil | ||
| } | ||
|
|
||
| for _, batch := range batches { | ||
| for batchIndex, batch := range batches { | ||
| if err := ctx.Err(); err != nil { | ||
| return bundle, err | ||
| } | ||
|
|
||
| // Log batch information before enrichment and upload | ||
| b.logger.Debug(). | ||
| Str("requestId", requestId). | ||
| Str("rootPath", bundle.GetRootPath()). | ||
| Str("bundleHash", bundle.GetBundleHash()). | ||
| Int("batchIndex", batchIndex+1). | ||
| Int("totalBatches", len(batches)). | ||
| Int("batchFileCount", len(batch.documents)). | ||
| Int("batchEstimatedSize", batch.getSize()). | ||
| Msg("Starting partial bundle upload batch") | ||
|
|
||
| b.enrichBatchWithFileContent(batch, bundle.GetRootPath()) | ||
| err := bundle.UploadBatch(s.Context(), requestId, batch) | ||
| if err != nil { | ||
| b.logger.Error(). | ||
| Err(err). | ||
| Str("requestId", requestId). | ||
| Int("batchIndex", batchIndex+1). | ||
| Int("totalBatches", len(batches)). | ||
| Msg("Failed to upload partial bundle batch") | ||
| return bundle, err | ||
| } | ||
|
|
||
| b.logger.Debug(). | ||
| Str("requestId", requestId). | ||
| Int("batchIndex", batchIndex+1). | ||
| Int("totalBatches", len(batches)). | ||
| Msg("Completed partial bundle upload batch") | ||
|
|
||
| batch.documents = make(map[string]deepcode.BundleFile) | ||
| } | ||
| } | ||
|
|
@@ -239,12 +264,51 @@ func (b *bundleManager) enrichBatchWithFileContent(batch *Batch, rootPath string | |
| b.logger.Error().Err(err).Str("file", filePath).Msg("Failed to decode Path") | ||
| continue | ||
| } | ||
|
|
||
| // Store original hash and metadata before reading file | ||
| originalHash := bundleFile.Hash | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure I understand the scenario. How would we already have a hash before adding the content? We should never read the same file twice, and if we do, it's a bug. |
||
| originalContentSize := bundleFile.ContentSize | ||
|
|
||
| // Log metadata before reading file content | ||
| b.logger.Debug(). | ||
| Str("filePath", filePath). | ||
| Str("absolutePath", absPath). | ||
| Str("originalHash", originalHash). | ||
| Int("originalContentSize", originalContentSize). | ||
| Msg("Preparing to read file for partial bundle upload") | ||
|
|
||
| content, err := os.ReadFile(absPath) | ||
| if err != nil { | ||
| b.logger.Error().Err(err).Str("file", filePath).Msg("Failed to read bundle file") | ||
| continue | ||
| } | ||
|
|
||
| // Compute hash from freshly read content to detect modifications | ||
| newHash, hashErr := util.Hash(content) | ||
| if hashErr != nil { | ||
| b.logger.Warn().Err(hashErr).Str("file", filePath).Msg("Failed to compute hash for freshly read content") | ||
| } else { | ||
| // Check if file was modified in flight | ||
| fileModified := originalHash != newHash | ||
| if fileModified { | ||
| b.logger.Warn(). | ||
| Str("filePath", filePath). | ||
| Str("absolutePath", absPath). | ||
| Str("originalHash", originalHash). | ||
| Str("newHash", newHash). | ||
| Int("originalContentSize", originalContentSize). | ||
| Int("newContentSize", len(content)). | ||
| Msg("File modification detected during partial bundle upload - file content changed between bundle creation and upload") | ||
| } else { | ||
| b.logger.Debug(). | ||
| Str("filePath", filePath). | ||
| Str("absolutePath", absPath). | ||
| Str("hash", newHash). | ||
| Int("contentSize", len(content)). | ||
| Msg("File content verified - no modifications detected") | ||
| } | ||
| } | ||
|
|
||
| utf8Content, err := util.ConvertToUTF8(content) | ||
| if err != nil { | ||
| b.logger.Error().Err(err).Str("file", filePath).Msg("Failed to convert bundle file to UTF-8") | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.