chore: add logs for bundle uploads and in-flight modification detection - #139
Draft
mihaibuzgau wants to merge 1 commit into
Draft
chore: add logs for bundle uploads and in-flight modification detection#139mihaibuzgau wants to merge 1 commit into
mihaibuzgau wants to merge 1 commit into
Conversation
|
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
| } | ||
|
|
||
| // Store original hash and metadata before reading file | ||
| originalHash := bundleFile.Hash |
There was a problem hiding this comment.
Not sure I understand the scenario. How would we already have a hash before adding the content? We should never read the same file twice, and if we do, it's a bug.
mihaibuzgau
force-pushed
the
chore/CLI-1364_add_bundle_debug
branch
from
February 23, 2026 10:47
700ca91 to
9ec0b8f
Compare
mihaibuzgau
marked this pull request as draft
February 23, 2026 10:54
mihaibuzgau
force-pushed
the
chore/CLI-1364_add_bundle_debug
branch
2 times, most recently
from
February 23, 2026 11:32
628e612 to
9039809
Compare
mihaibuzgau
force-pushed
the
chore/CLI-1364_add_bundle_debug
branch
from
February 23, 2026 15:45
9039809 to
94bdfc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
🚨After having merged, please update the
snyk-lsand CLI go.mod to pull in latest client.