-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor devcontainer setup and enhance R support #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
682e9d9
Refactor devcontainer setup to use dynamic VSCODE_COMMIT from .env fi…
DevNiall 4d96b4d
Update devcontainer configuration to remove .env file and read VSCODE…
DevNiall 7e55c49
Description fix
DevNiall c3bbc0f
Update README.md to clarify tagging for VS Code versions and combinat…
DevNiall 7ffc52f
Add R language support and related features to the dev container
DevNiall be4f5d8
Remove detailed R package installation options and configuration exam…
DevNiall File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,8 @@ This dev container is automatically built and published to GitHub Container Regi | |
| - `main` - Latest build from main branch | ||
| - `main-<commit-sha>` - Specific commit builds from main branch | ||
| - `pr-<number>` - Pull request builds for testing | ||
| - `vscode-<vscode-commit-sha>` - Builds with specific VS Code versions | ||
| - `vscode-<vscode-commit-sha>-<commit-sha>` - Combination of VS Code and git commit | ||
|
Comment on lines
+22
to
+23
|
||
|
|
||
| **Recommended**: Use `latest` for stable deployments or `main-<commit-sha>` for reproducible builds. | ||
|
|
||
|
|
@@ -64,6 +66,7 @@ This includes: | |
|
|
||
| - **Base**: Ubuntu 24.04 (Noble) via Microsoft's devcontainers base image | ||
| - **Python**: System Python with development tools (via devcontainer feature) | ||
| - **R**: Full R language support with development tools (via Rocker Project devcontainer feature) | ||
| - **Git**: Latest version with configuration support | ||
| - **Shell**: Zsh with Oh My Zsh (via common-utils feature) | ||
| - **Quarto**: Document publishing platform (latest version) | ||
|
|
@@ -77,6 +80,21 @@ This includes: | |
| - Rainbow CSV | ||
| - **VS Code Server**: Pre-installed for immediate development | ||
|
|
||
| ## 📊 R Language Support | ||
|
|
||
| This dev container includes comprehensive R language support through the [Rocker Project's devcontainer features](https://github.com/rocker-org/devcontainer-features). The R feature provides: | ||
|
|
||
| ### Features Available | ||
| - **R Installation**: Latest R version via apt package manager | ||
| - **Development Tools**: devtools, renv for package management | ||
| - **IDE Integration**: | ||
| - languageserver package for VS Code R extension support | ||
| - httpgd package for interactive graphics | ||
| - rmarkdown for document generation | ||
| - **Jupyter Integration**: R kernel for Jupyter notebooks | ||
| - **Interactive Console**: radian (enhanced R console with syntax highlighting) | ||
| - **Debugging Support**: vscDebugger package for VS Code R debugging | ||
|
|
||
| ## ⚙️ VS Code Server | ||
|
|
||
| The container comes with VS Code Server pre-installed for immediate development. For TRE-specific VS Code Server configuration, see the [SDF TRE Setup Guide](SDF_TRE_SETUP.md). | ||
|
|
@@ -94,10 +112,13 @@ The container is built automatically with smart tagging: | |
|
|
||
| - **Main Branch Pushes**: Creates `latest`, `main`, and `main-<commit-sha>` tags | ||
| - **Pull Requests**: Creates `pr-<number>` tags for testing | ||
| - **VS Code Commits**: Creates `vscode-<vscode-commit-sha>` and `vscode-<vscode-commit-sha>-<commit-sha>` tags | ||
| - **Manual Dispatch**: Available for on-demand builds | ||
| - **Platform**: linux/amd64 optimized for development speed | ||
|
|
||
| ### Tag Strategy | ||
| - Use `latest` for the most recent stable release | ||
| - Use `main-<commit-sha>` when you need reproducible builds | ||
| - Use `pr-<number>` tags to test specific pull request changes | ||
| - Use `vscode-<commit-sha>` tags to match specific VS Code versions | ||
| - Use `vscode-<commit-sha>-<container-commit-sha>` tags for a combination of VS Code and git commits | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command assumes a specific format for the VSCODE_COMMIT field in the JSON file. The
cut -d " " -f 2will fail if there are variations in spacing or if the field is formatted differently (e.g.,\"VSCODE_COMMIT\":\"value\"). Consider usingjqfor more reliable JSON parsing:jq -r '.build.args.VSCODE_COMMIT // empty' .devcontainer/devcontainer.json