Skip to content

Refactor devcontainer setup and enhance R support - #3

Merged
DevNiall merged 6 commits into
mainfrom
feature/config
Sep 25, 2025
Merged

Refactor devcontainer setup and enhance R support#3
DevNiall merged 6 commits into
mainfrom
feature/config

Conversation

@DevNiall

Copy link
Copy Markdown
Contributor
  • Refactor the devcontainer setup to dynamically read the VS Code commit from the configuration file amd tag image with it.
  • Update the GitHub Actions workflow to output commit information and clarify tagging for * VS Code versions in the README.
  • Added missing R language information to the README,

@github-actions

Copy link
Copy Markdown

🔒 Trivy Security Scan Results

Status: ⚠️ Vulnerabilities found (see details in artifacts)
Vulnerabilities Found: 129 critical/high severity issues

⚠️ Action Required: Critical or high severity vulnerabilities detected.

Top 10 Critical/High Severity Vulnerabilities:

Type Package Vulnerability Severity Fixed Version
gobinary stdlib CVE-2024-24790 CRITICAL 1.21.11, 1.22.4
gobinary stdlib CVE-2024-24790 CRITICAL 1.21.11, 1.22.4
gobinary stdlib CVE-2024-24790 CRITICAL 1.21.11, 1.22.4
gobinary stdlib CVE-2024-24790 CRITICAL 1.21.11, 1.22.4
node-pkg grunt CVE-2020-7729 HIGH 1.3.0
node-pkg grunt CVE-2022-1537 HIGH 1.5.3
node-pkg npm CVE-2018-7408 HIGH 5.7.1
node-pkg npm CVE-2019-16775 HIGH 6.13.3
node-pkg npm CVE-2019-16776 HIGH 6.13.3
node-pkg npm CVE-2019-16777 HIGH 6.13.4

... and 4 more issues.

📊 Scan Details

  • Image: ghcr.io/smartdatafoundry/devcontainer
  • Scan Date: 2025-09-25 09:23:03 UTC
  • Total Vulnerabilities: 129

Action Run: view run
Trivy Report: view report

@DevNiall
DevNiall requested a review from Copilot September 25, 2025 11:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the devcontainer setup to dynamically read VS Code commit information from the configuration file and implement intelligent tagging based on VS Code versions. The changes enhance documentation and improve build automation by adding support for VS Code-specific tagging and comprehensive R language documentation.

  • Adds dynamic VS Code commit extraction from devcontainer.json configuration
  • Implements new tagging strategy for VS Code version-specific builds
  • Enhances README with comprehensive R language support documentation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
README.md Added R language support documentation and VS Code version tagging information
.github/workflows/build-devcontainer.yml Implemented dynamic VS Code commit reading and enhanced tagging with commit information output

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

- name: Read VSCODE_COMMIT from devcontainer.json
id: vscode-commit
run: |
VSCODE_COMMIT=$(grep 'VSCODE_COMMIT' .devcontainer/devcontainer.json | tr -d '"' | cut -d " " -f 2)

Copilot AI Sep 25, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command assumes a specific format for the VSCODE_COMMIT field in the JSON file. The cut -d " " -f 2 will fail if there are variations in spacing or if the field is formatted differently (e.g., \"VSCODE_COMMIT\":\"value\"). Consider using jq for more reliable JSON parsing: jq -r '.build.args.VSCODE_COMMIT // empty' .devcontainer/devcontainer.json

Suggested change
VSCODE_COMMIT=$(grep 'VSCODE_COMMIT' .devcontainer/devcontainer.json | tr -d '"' | cut -d " " -f 2)
VSCODE_COMMIT=$(jq -r '.build.args.VSCODE_COMMIT // empty' .devcontainer/devcontainer.json)

Copilot uses AI. Check for mistakes.
Comment thread README.md
Comment on lines +22 to +23
- `vscode-<vscode-commit-sha>` - Builds with specific VS Code versions
- `vscode-<vscode-commit-sha>-<commit-sha>` - Combination of VS Code and git commit

Copilot AI Sep 25, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an inconsistency in the commit SHA format description. Line 123 uses vscode-<commit-sha> while line 22 uses vscode-<vscode-commit-sha>. The format should be consistent throughout the documentation.

Copilot uses AI. Check for mistakes.
@DevNiall
DevNiall merged commit be4f5d8 into main Sep 25, 2025
1 of 5 checks passed
@DevNiall
DevNiall deleted the feature/config branch September 25, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants