Refactor devcontainer setup and enhance R support - #3
Conversation
DevNiall
commented
Sep 24, 2025
- Refactor the devcontainer setup to dynamically read the VS Code commit from the configuration file amd tag image with it.
- Update the GitHub Actions workflow to output commit information and clarify tagging for * VS Code versions in the README.
- Added missing R language information to the README,
…le and update GitHub Actions workflow to read and output commit information
…_COMMIT directly from devcontainer.json
…ions with git commits
…ples from README.md
🔒 Trivy Security Scan ResultsStatus: Top 10 Critical/High Severity Vulnerabilities:
... and 4 more issues. 📊 Scan Details
Action Run: view run |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the devcontainer setup to dynamically read VS Code commit information from the configuration file and implement intelligent tagging based on VS Code versions. The changes enhance documentation and improve build automation by adding support for VS Code-specific tagging and comprehensive R language documentation.
- Adds dynamic VS Code commit extraction from devcontainer.json configuration
- Implements new tagging strategy for VS Code version-specific builds
- Enhances README with comprehensive R language support documentation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Added R language support documentation and VS Code version tagging information |
| .github/workflows/build-devcontainer.yml | Implemented dynamic VS Code commit reading and enhanced tagging with commit information output |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| - name: Read VSCODE_COMMIT from devcontainer.json | ||
| id: vscode-commit | ||
| run: | | ||
| VSCODE_COMMIT=$(grep 'VSCODE_COMMIT' .devcontainer/devcontainer.json | tr -d '"' | cut -d " " -f 2) |
There was a problem hiding this comment.
This command assumes a specific format for the VSCODE_COMMIT field in the JSON file. The cut -d " " -f 2 will fail if there are variations in spacing or if the field is formatted differently (e.g., \"VSCODE_COMMIT\":\"value\"). Consider using jq for more reliable JSON parsing: jq -r '.build.args.VSCODE_COMMIT // empty' .devcontainer/devcontainer.json
| VSCODE_COMMIT=$(grep 'VSCODE_COMMIT' .devcontainer/devcontainer.json | tr -d '"' | cut -d " " -f 2) | |
| VSCODE_COMMIT=$(jq -r '.build.args.VSCODE_COMMIT // empty' .devcontainer/devcontainer.json) |
| - `vscode-<vscode-commit-sha>` - Builds with specific VS Code versions | ||
| - `vscode-<vscode-commit-sha>-<commit-sha>` - Combination of VS Code and git commit |
There was a problem hiding this comment.
There's an inconsistency in the commit SHA format description. Line 123 uses vscode-<commit-sha> while line 22 uses vscode-<vscode-commit-sha>. The format should be consistent throughout the documentation.