Skip to content

refactor: mark PartitionField and SortField getters [[nodiscard]] #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
smaheshwar-pltr wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

refactor: mark PartitionField and SortField getters [[nodiscard]] #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0f799b
refactor: mark PartitionField and SortField getters [[nodiscard]]
Jun 27, 2026
02b386b
Merge branch 'main' into cleanup/nodiscard-getters
Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/iceberg/partition_field.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,18 +45,18 @@ class ICEBERG_EXPORT PartitionField : public util::Formattable {
std::shared_ptr<Transform> transform);

/// \brief Get the source field ID.
int32_t source_id() const;
[[nodiscard]] int32_t source_id() const;

/// \brief Get the partition field ID.
int32_t field_id() const;
[[nodiscard]] int32_t field_id() const;

/// \brief Get the partition field name.
std::string_view name() const;
[[nodiscard]] std::string_view name() const;

/// \brief Get the transform type.
std::shared_ptr<Transform> const& transform() const;
[[nodiscard]] std::shared_ptr<Transform> const& transform() const;

std::string ToString() const override;
[[nodiscard]] std::string ToString() const override;

friend bool operator==(const PartitionField& lhs, const PartitionField& rhs) {
return lhs.Equals(rhs);
Expand Down
12 changes: 6 additions & 6 deletions src/iceberg/sort_field.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,21 +96,21 @@ class ICEBERG_EXPORT SortField : public util::Formattable {
SortDirection direction, NullOrder null_order);

/// \brief Get the source field ID.
int32_t source_id() const;
[[nodiscard]] int32_t source_id() const;

/// \brief Get the transform type.
const std::shared_ptr<Transform>& transform() const;
[[nodiscard]] const std::shared_ptr<Transform>& transform() const;

/// \brief Get the sort direction.
SortDirection direction() const;
[[nodiscard]] SortDirection direction() const;

/// \brief Get the null order.
NullOrder null_order() const;
[[nodiscard]] NullOrder null_order() const;

/// \brief Checks whether this field's order satisfies another field's order.
bool Satisfies(const SortField& other) const;
[[nodiscard]] bool Satisfies(const SortField& other) const;

std::string ToString() const override;
[[nodiscard]] std::string ToString() const override;

friend bool operator==(const SortField& lhs, const SortField& rhs) {
if (&lhs == &rhs) {
Expand Down
Loading