refactor: mark PartitionField and SortField getters [[nodiscard]]#17
Draft
smaheshwar-pltr wants to merge 2 commits into
Draft
refactor: mark PartitionField and SortField getters [[nodiscard]]#17smaheshwar-pltr wants to merge 2 commits into
smaheshwar-pltr wants to merge 2 commits into
Conversation
These are pure accessors and predicates; discarding their result is a bug. Mirrors the existing [[nodiscard]] annotations on the analogous SchemaField getters in schema_field.h. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
[[nodiscard]]to the pure accessors and predicates onPartitionField(source_id,field_id,name,transform,ToString) andSortField(source_id,transform,direction,null_order,Satisfies,ToString).Why
These are side-effect-free getters/predicates, so discarding their result is almost certainly a bug worth a compiler diagnostic. This mirrors the existing
[[nodiscard]]annotations on the analogousSchemaFieldgetters inschema_field.h. No in-tree call site discards these return values, so the change is clean under the project's-Werrorbuild.