Remove the remaining non-RoCEv2 Verilog from surf - #1469
Merged
Conversation
Both models are vendor Verilog/SystemVerilog with no VHDL equivalent, so they cannot be simulated by the GHDL/cocotb flow and cannot be reduced to a subset of their files: arch_package.sv includes arch_defines.v, and the four *_ddr3_parameters.vh headers exist only to be included by ddr3.v. Delete devices/Micron/ddr3 and devices/Micron/ddr4 in full, including the per-device manifests that carried the Verilog-specific USED_IN and FILE_TYPE properties, and drop the two now-dangling loadRuckusTcl lines from devices/Micron/ruckus.tcl. mt28ew, n25q, and p30 are unchanged. Projects whose testbenches include ddr3.v or arch_package.sv from surf/devices/Micron/ddr3/tb or ddr4/tb must vendor those Micron models locally.
The SaciSlaveAnalog module has no instantiation anywhere in the repository. It reached builds only through the loadSource -sim_only -dir glob over protocols/saci/saci1/sim, so no manifest change is needed.
The four UdpDebugBridge_stub.v files are Vivado synth-stub byproducts that no manifest loads: xilinx/xvc-udp/ruckus.tcl loads only UdpDebugBridge.dcp, and the 7Series and UltraScale DCP-regeneration manifests load only dcp/core/*.vhd. The sibling UdpDebugBridge_stub.vhd and .vho reference files are kept.
ruck314
marked this pull request as ready for review
August 17, 2026 16:09
bengineerd
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the Verilog and SystemVerilog that #1468 does not cover, so that after both changes land the only non-VHDL sources left in surf are
protocols/i2c/rtlandsimlink. Deletes both Micron DDR vendor simulation models (devices/Micron/ddr3anddevices/Micron/ddr4), the unusedSaciSlaveAnalog.vsimulation model, and the four generatedUdpDebugBridge_stub.vsynthesis stubs.Downstream impact: projects whose testbenches include
ddr3.vorarch_package.svfromsurf/devices/Micron/ddr3/tborddr4/tbmust vendor those Micron models locally.Details
arch_package.svincludesarch_defines.v, and the four*_ddr3_parameters.vhheaders exist only to be included byddr3.v, so deleting just the.vfiles would leave two non-functional vendor models.devices/Micron/ruckus.tcldrops the two now-danglingloadRuckusTcllines;mt28ew,n25q, andp30are unchanged. The per-device manifests that carried the Verilog-specificUSED_IN {implementation}andFILE_TYPE {Verilog Header}properties go with their directories, so nothing is left to patch.protocols/saci/saci1/sim/SaciSlaveAnalog.vhad no instantiation anywhere in the repository. It reached builds only through theloadSource -sim_only -dirglob overprotocols/saci/saci1/sim, so no manifest change is needed. The remaining VHDL in that directory is untouched.xilinx/xvc-udp/dcp/{7Series,UltraScale}/{Impl,Stub}/images/UdpDebugBridge_stub.vfiles are Vivado synth-stub byproducts that no manifest loads.xilinx/xvc-udp/ruckus.tclloads onlyUdpDebugBridge.dcp, and the two DCP-regeneration manifests load onlydcp/core/*.vhd. The siblingUdpDebugBridge_stub.vhdand.vhoreference files are kept, since they document the black-box port list without reintroducing Verilog.Validation performed:
make MODULES="$PWD" importexited 0.make MODULES="$PWD" analysisexited 0, analyzing 491 files with no errors or warnings.pytest -n auto --dist=worksteal tests: 911 passed, 21 skipped, no failures. The skips are pre-existing.Related
ethernet/RoCEv2.