Skip to content

Convert createClient/shutdown failures to Unhealthy in DynamoDB check #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sksamuel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Convert createClient/shutdown failures to Unhealthy in DynamoDB check #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions cohort-aws-dynamo/src/main/kotlin/com/sksamuel/cohort/aws/dynamo/DynamoDBHealthCheck.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,26 @@ class DynamoDBHealthCheck(

private fun <T> AmazonDynamoDB.use(f: (AmazonDynamoDB) -> T): Result<T> {
val result = runCatching { f(this) }
this.shutdown()
runCatching { this.shutdown() }
return result
}

override suspend fun check(): HealthCheckResult {
return runInterruptible(Dispatchers.IO) {
createClient().use {
it.listTables(1)
// Catch errors from createClient() itself (AWS region/credential resolution can throw
// synchronously on builder().build()). Previously such failures escaped runInterruptible
// and propagated out of check() instead of producing an Unhealthy result.
return runCatching {
runInterruptible(Dispatchers.IO) {
createClient().use {
it.listTables(1)
}
}
}.fold(
{ HealthCheckResult.healthy("DynamoDB access successful") },
{ HealthCheckResult.unhealthy("Could not connect to DynamoDB", it) }
{ it.fold(
{ HealthCheckResult.healthy("DynamoDB access successful") },
{ HealthCheckResult.unhealthy("Could not connect to DynamoDB", it) }
)},
{ HealthCheckResult.unhealthy("Could not connect to DynamoDB", it) },
)
}
}