Convert createClient/shutdown failures to Unhealthy in DynamoDB check - #234
Open
sksamuel wants to merge 1 commit into
Open
Convert createClient/shutdown failures to Unhealthy in DynamoDB check#234sksamuel wants to merge 1 commit into
sksamuel wants to merge 1 commit into
Conversation
Two problems with the old wiring: 1. `createClient()` is a user-supplied lambda invoked inside `runInterruptible`. If it threw synchronously (typical: AWS region or credential resolution failure on `AmazonDynamoDBClient.builder().build()`), the exception propagated through `runInterruptible` and out of `check()` — the `.fold` on `Result` was never reached. The registry sees an exception rather than the expected Unhealthy. 2. The inner `use` extension called `shutdown()` unconditionally. If `shutdown()` itself threw (rare but possible during AWS SDK teardown), the original check failure was masked. Wrap the whole runInterruptible in runCatching and guard the shutdown call so the original cause always reaches the operator. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wrap the whole `runInterruptible` in `runCatching` and guard the shutdown.
Test plan
🤖 Generated with Claude Code