Skip to content

update target for gt2n#223

Merged
gadfort merged 1 commit into
mainfrom
gt2n-target
Jul 10, 2026
Merged

update target for gt2n#223
gadfort merged 1 commit into
mainfrom
gt2n-target

Conversation

@gadfort

@gadfort gadfort commented Jul 10, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features
    • Added automatic elaboration-language detection when no language is specified.
    • Added an optional language setting for GT2N demo flows, supporting both full ASIC and synthesis-only workflows.

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

gt2n_demo now accepts an optional elaboration language, detects it when unspecified, and passes the resolved value to both ASIC and synthesis flows.

Changes

GT2N language configuration

Layer / File(s) Summary
Language resolution and flow wiring
lambdapdk/gt2n/target.py
Adds the optional language parameter, derives it with detect_elaboration_language when omitted, and passes it to ASICFlow and SynthesisFlow.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is clearly related to the gt2n target update, though it is broader than the specific language-detection change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gt2n-target

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
lambdapdk/gt2n/target.py (1)

22-38: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Document the new language parameter.

The docstring lists all other parameters but omits language. Add a brief entry to keep the public contract complete.

📝 Proposed docstring update
             * route_np (int): Parallelism for routing.
             * timing_np (int): Parallelism for timing analysis (synthesis-only flow).
+            * language (Optional[str]): Elaboration language (e.g. "verilog", "vhdl").
+              If None, the language is auto-detected from the project.
         """
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lambdapdk/gt2n/target.py` around lines 22 - 38, Add the missing language
parameter to the docstring for the configuration function, alongside the
existing project and parallelism parameter descriptions, including a brief
description of its purpose.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@lambdapdk/gt2n/target.py`:
- Around line 22-38: Add the missing language parameter to the docstring for the
configuration function, alongside the existing project and parallelism parameter
descriptions, including a brief description of its purpose.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8668d7a9-93af-457c-8e64-360afc6f2a28

📥 Commits

Reviewing files that changed from the base of the PR and between e6f6b20 and a8bfa2e.

📒 Files selected for processing (1)
  • lambdapdk/gt2n/target.py

@gadfort gadfort merged commit 9708488 into main Jul 10, 2026
4 checks passed
@gadfort gadfort deleted the gt2n-target branch July 10, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant