update target for gt2n#223
Merged
Merged
Conversation
📝 WalkthroughWalkthrough
ChangesGT2N language configuration
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
lambdapdk/gt2n/target.py (1)
22-38: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueDocument the new
languageparameter.The docstring lists all other parameters but omits
language. Add a brief entry to keep the public contract complete.📝 Proposed docstring update
* route_np (int): Parallelism for routing. * timing_np (int): Parallelism for timing analysis (synthesis-only flow). + * language (Optional[str]): Elaboration language (e.g. "verilog", "vhdl"). + If None, the language is auto-detected from the project. """🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@lambdapdk/gt2n/target.py` around lines 22 - 38, Add the missing language parameter to the docstring for the configuration function, alongside the existing project and parallelism parameter descriptions, including a brief description of its purpose.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@lambdapdk/gt2n/target.py`:
- Around line 22-38: Add the missing language parameter to the docstring for the
configuration function, alongside the existing project and parallelism parameter
descriptions, including a brief description of its purpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit