Skip to content

Improve installer template testability (accessibility-first) #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Soner (shyim) merged 1 commit into from
Jun 22, 2026
Merged

Improve installer template testability (accessibility-first) #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Resources/views/install.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
<div class="alert alert-error" id="log-error" style="display: none">{{ 'shopware.update.steps.install.error'|trans|raw }}</div>

<div id="log-card" style="display: none;">
<pre class="form-control" id="log-output" style="height: 60vh;"></pre>
<pre class="form-control" id="log-output" style="height: 60vh;" data-testid="install-log-output"></pre>
</div>

</div>
Expand Down
4 changes: 2 additions & 2 deletions Resources/views/php_config.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@

<form method="POST" id="submit">
<div class="form-group">
<label for="name">{{ 'shopware.update.steps.configure_php.pathInput'|trans }}</label>
<input class="form-control" type="text" name="phpBinary" value="{{ phpBinary }}">
<label for="phpBinary">{{ 'shopware.update.steps.configure_php.pathInput'|trans }}</label>
<input class="form-control" type="text" id="phpBinary" name="phpBinary" value="{{ phpBinary }}">
</div>
</form>
</div>
Expand Down
2 changes: 1 addition & 1 deletion Resources/views/update.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<div class="card-body">
<h5 class="card-title">{{ 'shopware.update.steps.update.log'|trans }}</h5>

<pre class="form-control" id="log-output" style="height: 60vh"></pre>
<pre class="form-control" id="log-output" style="height: 60vh" data-testid="update-log-output"></pre>
</div>
</div>
</div>
Expand Down
Loading