Repository navigation
Improve installer template testability (accessibility-first) - #23
Merged
Merged
Conversation
Make the installer reliably targetable from acceptance tests while preferring accessible locators over test-only hooks: - Fix the PHP binary field's broken label association (the <label> used for="name" but no matching id existed), so the input is reachable via an accessible label locator instead of needing a test id. - Add data-testid only to the streamed log <pre> elements on the install and update pages, which have no role, accessible name or stable text and therefore cannot be located accessibly. Everything else (buttons, links, headings, labeled selects, visible text, alerts) is already reachable through role/label/text locators, so no test ids were added there. All 85 existing tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TJMFV7jMT6L1Re9DPQtfwF
Soner (shyim)
force-pushed
the
claude/lucid-allen-2g1i2h
branch
from
June 22, 2026 07:41
07797d6 to
3656289
Compare
Soner (shyim)
changed the title
Soner (shyim)
marked this pull request as ready for review
June 22, 2026 07:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make the installer reliably targetable from acceptance tests, preferring accessible locators (
getByRole/getByLabel/getByText) over test-only hooks and addingdata-testidonly where no accessible handle exists.Changes
php_config.html.twig<label for="name">→for="phpBinary", add matchingidto the input)forpointed at a non-existent id, sogetByLabel('PHP binary')didn't work. Fixing accessibility is preferred over adding a test id.install.html.twigdata-testid="install-log-output"on the log<pre><pre>has no role, accessible name or stable text — it can't be located accessibly.update.html.twigdata-testid="update-log-output"on the log<pre>Everything else in the installer (buttons, links, headings, labeled selects, visible text, alerts) is already reachable via role/label/text locators, so no test ids were added there.
Notes
shopware/shopware: the acceptance suite'sUpdate.spec.tsalready uses accessiblegetByRolelocators for this installer's steps (Continue / Update Shopware / Finish / Open Administration), and those remain valid.🤖 Generated with Claude Code
https://claude.ai/code/session_01TJMFV7jMT6L1Re9DPQtfwF