refactor(glyphs)!: remove legacy-kwarg shims + widen per-call preset overrides - #287
Merged
Conversation
Follow-up to the grouped render-parameter refactor (#274): drop the backward-compatible shims for the old loose keywords and complete the facet parameter grouping. - remove all deprecation shims (_resolve_point_overlay, _resolve_frame_label, _resolve_renamed_kwarg, _warn_deprecated_cbar_kwargs, _pop_first) across array_glyph, colorbar, and the six other glyphs - remove the no_elem alias; rename text_colors to cell_value_text_colors - group facet coordinate labels into PanelLabels; rename facet figsize to figure_size - add a grouped render-parameter migration guide and wire it into mkdocs - drop the deprecation tests, unwrap the still-functional cbar_*/ticks_spacing tests, and convert bare-array point tests to PointOverlay BREAKING CHANGE: removed loose keywords now raise the ordinary TypeError, and a bare array for points raises AttributeError. text_colors is renamed to cell_value_text_colors, no_elem to num_domain_cells, and facet's figsize to figure_size. Loose cbar_* / ticks_spacing keys still work but no longer emit a deprecation warning. Closes #281, #283, #285
…anelLabels pointer
…CAMS presets Rebased the widen-style-overrides work onto the grouped render-parameter refactor + legacy-kwarg-shim removal (PR #286). Squashes the branch's own 16 commits into one integration commit; all code is preserved, the loose pre-shim-removal kwargs it relied on are dropped in favour of the group objects already on main. - widen per-call DATA_STYLES overrides (extend/levels/bands/alpha/ alpha_range) via data_style=DataStyle, with resolve_style_overrides() - vendor the full scientific perceptually-uniform colour-map set and the CAMS atmospheric-composition preset set; neutral provenance naming - DataStyle alpha_range / bands validation and opacity-mode clearing - keep colour-map download scripts local-only - add example notebooks and the style-override test suite Integrated cleanly onto the shim-removed API: full suite 2210 passed.
…CAMS presets Rebased the widen-style-overrides work onto the grouped render-parameter refactor + legacy-kwarg-shim removal (PR #286). Squashes the branch's own 16 commits into one integration commit; all code is preserved, the loose pre-shim-removal kwargs it relied on are dropped in favour of the group objects already on main. - widen per-call DATA_STYLES overrides (extend/levels/bands/alpha/ alpha_range) via data_style=DataStyle, with resolve_style_overrides() - vendor the full scientific perceptually-uniform colour-map set and the CAMS atmospheric-composition preset set; neutral provenance naming - DataStyle alpha_range / bands validation and opacity-mode clearing - keep colour-map download scripts local-only - add example notebooks and the style-override test suite Integrated cleanly onto the shim-removed API: full suite 2210 passed.
…Glyph + KDEGlyph)
…our count + norm)
…shade=None) clears
…itive complexity (Sonar S3776)
…117 (drop redundant fixture scope)
|
This was referenced Aug 11, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Consolidates two bodies of work on top of the squashed grouped-render-parameter refactor (PR #274, already on
main):_resolve_point_overlay,_resolve_frame_label,_resolve_renamed_kwarg,_warn_deprecated_cbar_kwargs,_DEPRECATED_CBAR_KWARGS,no_elem), renamestext_colors→cell_value_text_colorsandno_elem→num_domain_cells, groupsfacet's coordinate labels intoPanelLabelsand renamesfacet(figsize=)→figure_size, and adds amigration guide (
docs/migration.md, wired into the mkdocs nav). Removed keywords now raise a clear error.data_style=DataStyle(...)toextend/levels/bands/alpha/alpha_rangevia a newresolve_style_overrideshelper, and vendors the scientific and CAMSperceptually-uniform preset sets.
The two streams were reconciled by hand; a two-round
/reviewpass then caught and fixed several fixes the mergehad silently reverted (all with regression tests re-added):
data_style(ArrayGlyph + KDEGlyph),Contour(levels=)discretisation,animate(contour=...)on ArrayGlyph + MeshGlyph,apply_style(hillshade=None)clear semantics (the_UNSET_HILLSHADEsentinel),publication_map'sstyle=/data_style=collision guard,Dependencies: none.
Note: this branch was cut from
feat/widen-style-overridesand carries that style work; if that branch keepsadvancing, its later commits are not yet included here and would need reconciling before this merges.
Issues
PanelLabels+figure_size)Type of change
Check relevant points.
How Has This Been Tested?
Run against the external uv environment with the branch's
srconPYTHONPATH(
PYTHONPATH=<worktree>/src C:/python-environments/uv/cleopatra/Scripts/python.exe -m pytest ...).pytest --doctest-modules src/...)./reviewcompleted; every must-fix and should-fix finding resolved with aregression test, and the previously-deleted guard tests were restored.
ruff checkintroduces no newsrc/findings vsmain(the ~10 pre-existingmainfindings areunchanged); the branch-introduced test-file
I001violations were fixed.Checklist: