Fix entry-port fork fanout legs collapsing onto one opening vertex - #1965
Closed
pinin4fjords with Copilot wants to merge 3 commits into
Closed
Fix entry-port fork fanout legs collapsing onto one opening vertex#1965pinin4fjords with Copilot wants to merge 3 commits into
pinin4fjords with Copilot wants to merge 3 commits into
Conversation
Co-authored-by: pinin4fjords <5775915+pinin4fjords@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix entry-port fork legs sharing turn vertex in starburst rendering
Fix entry-port fork fanout legs collapsing onto one opening vertex
Sep 8, 2026
Add two curve-invariant repro fixtures that exercise the previously un-taken arms of the entry-port fused-opening peel-delay seat in _route_entry_runway: the target-row-clear branch widens the source-side seat only when the nearest bypassed station leaves room, and the target-row-blocked branch does likewise against the port-to-target span. Triage the two defensive guards in _source_needs_fused_opening_seat (a forking port source is always a registered entry port; its section always resolves) and regenerate the coverage matrix and baseline. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
Render preview is ready for review: This preview shows only the renders that changed compared to |
Member
|
Closing — the underlying issue (#1831) has been closed as won't-do. On review, the pre-fix starburst rendering doesn't read as a problem on the real map it was reported from; the staggered version isn't a visible improvement for single-line forks. This change also introduced a genuine new line crossing in examples/topologies/funcprofiler_upstream.mmd (failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entry-port-originated same-line fanouts in LR/RL sections could open from a shared source-side turn, producing a starburst instead of a depth-ordered staircase. The affected path was split across plain intra-section diagonals and entry-runway-owned branches, so only some siblings peeled correctly.
Routing
_route_entry_runway()that_route_diagonal()already uses, so deeper runway-owned siblings peel earlier instead of reusing the same lead X.Regression lock
riboseq_inter_row_corridorreproShape of the fix