Repository navigation
Test malformed HMMA helper signatures - #870
Open
thehobbit85 wants to merge 1 commit into
Open
thehobbit85 wants to merge 1 commit into
thehobbit85 wants to merge 1 commit into
Conversation
thehobbit85
force-pushed
the
codex/fix-heaps-fixture-types
branch
from
November 1, 2026 13:33
495c412 to
eb7211a
Compare
thehobbit85
changed the title
thehobbit85
force-pushed
the
codex/fix-heaps-fixture-types
branch
from
November 1, 2026 13:54
eb7211a to
162bc26
Compare
thehobbit85
changed the title
thehobbit85
force-pushed
the
codex/fix-heaps-fixture-types
branch
from
November 1, 2026 20:30
162bc26 to
b45329b
Compare
thehobbit85
force-pushed
the
codex/fix-heaps-fixture-types
branch
from
November 2, 2026 05:59
b45329b to
62ed942
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add regression coverage for malformed HMMA helper signatures after upstream
0e8503e7incorporated the production guards and Heaps fixture assertion. Main fixes the original lint failures but lacks these malformed ordinary/scratch parameter-name and output-reference cases. Each must raiseValueErroridentifying the bad parameter; the tests detect removal of either guard.Revision
62ed942b99a8e73eb19ce44e81814d24babcf5f3integrates main99330eb81c873c3aafe9fc92194c9687d77fcdbb. The remaining test/reference patch is unchanged. There is no production implementation, chain-header, baseline or suppression change.Fresh validation:
python3 -m unittest dm.gfx.tests.test_dmsh_hmma dm.tools.tests.test_nsp_chain dm.tools.tests.test_docspasses all30 tests, including the synthetic GPU case. Pinned Python lint passes with391 baseline findings, zero new or stale. Main ancestry, range-diff and whitespace checks pass. Current-head CI is pending; the seven successful checks on priorb45329b8are historical.Earlier Heaps checks, negative controls and valid-output comparisons retain their original revision scope. Installed Xcode27.0/Metal.921 differs from supported27.2/.922. This test-only change does not change game behavior, so no game regression run is needed; no fresh game, device or performance result is claimed. The shader reference retains the durable guard explanation, with validation recorded here. No agent artifacts or game data are included.