Repository navigation
launcher: add shared localization tables and stable settings keys - #780
Open
thehobbit85 wants to merge 1 commit into
Open
thehobbit85 wants to merge 1 commit into
thehobbit85 wants to merge 1 commit into
Conversation
thehobbit85
force-pushed
the
codex/launcher-localization
branch
3 times, most recently
from
October 31, 2026 13:28
967aebc to
9256302
Compare
thehobbit85
force-pushed
the
codex/launcher-localization
branch
from
October 31, 2026 22:09
9256302 to
2c9b257
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #775.
The iOS and Mac settings launchers have no translation resources, and dynamic settings labels bypass string lookup. Add one shared
Launcher.stringscatalog and route their buttons, headings, status text, menus and setting rows through it. A translator can add<locale>.lproj/Launcher.stringswithout editing Swift or the settings table.The settings JSON gains optional
label_key,note_key,section_keyandoption_keysfields derived from environment variables and raw choice values. Existing English labels remain the fallback, including for older JSON and missing translations. Schema 1, environment values, tested defaults, section grouping and saved preferences retain their meanings. The launcher follows the app's preferred system language independently ofDM_LANG.The English catalog has 79 entries. Xcode includes it in both prepared projects and unsigned builds; the Mac packer copies all locale resources and invalidates reuse when a string table is added, changed or removed. The front-end contract documents the keys and contribution workflow. This provides the layer for the reporter's offered zh-Hans contribution; it does not include a Chinese translation.
Maintenance refresh (2026-10-31, 22:02 UTC) onto fixed main
5474c6f34789a41770868564fbf4e9e32fc57584: head2c9b2579f74a2527560bb8d4c4b2c72c3e5933bb. Conflict-free rebase; range-diff confirms the localization patch is unchanged. Main's guarded rewriter recognition, audio diagnostic mailbox and benchmark offline-archive default remain intact. iOS DLC startup/transfer behavior and the prebuild visibility dependency are preserved. Fresh paginated review found no comments, reviews or inline feedback.Fresh validation on this head:
git diff --checkpasses.t_audio_stats: 22 checks passed onfe348cea; this head has identical audio code, fixture and host-test Makefile. New-head CI is pending after publication.Reused historical coverage:
925630295b9epassed 44 localization/DLC/settings/docs tests and clean lint. Earlier779fc7082b1fpassed four native iOS/Mac × current/legacy JSON dependency cases and all seven CI checks. Swift/resource/Mac-packer and iOS source/build-tool inputs are unchanged by this main advance. The broad unsigned iOS smoke and Mac bundle suites were not repeated;19fb0840adb5previously passed production unsigned smoke with synthetic modules and packaged string-table verification, 753 tool tests (16 skipped), 41 iOS tests and 51 final affected checks.No gameplay, device transfer, game extraction or fresh game shader/interface comparison was performed in this pass. Historical game-related reports apply only to their recorded revisions.