crate: annotate unstalbe *LAST constants#5120
Open
dybucc wants to merge 1 commit into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6d89662 to
ff01f04
Compare
This comment has been minimized.
This comment has been minimized.
05d5fe8 to
bd2bb5b
Compare
This was referenced May 28, 2026
*LAST constants fitting #3131
3 tasks
bf8abd7 to
b1ea172
Compare
This comment has been minimized.
This comment has been minimized.
3 tasks
dybucc
added a commit
to dybucc/libc
that referenced
this pull request
Jun 8, 2026
This patch is a follow up to rust-lang#5120. That PR deprecated the now removed symbols such that it could be included in a stable release. This patch targets the 1.0 release, by altogether removinga the symbols and updating the SemVer-tracking file. See the accompanying PR for more details.
dybucc
added a commit
to dybucc/libc
that referenced
this pull request
Jun 9, 2026
This patch is a follow up to rust-lang#5120. That PR deprecated the now removed symbols such that it could be included in a stable release. This patch targets the 1.0 release, by altogether removinga the symbols and updating the SemVer-tracking file. See the accompanying PR for more details.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
CI actually passes. There seems to be an issue with a glob import that is not used, but this has not |
dybucc
added a commit
to dybucc/libc
that referenced
this pull request
Jun 15, 2026
This patch is a follow up to rust-lang#5120. That PR deprecated the now removed symbols such that it could be included in a stable release. This patch targets the 1.0 release, by altogether removinga the symbols and updating the SemVer-tracking file. See the accompanying PR for more details.
8e5ad96 to
8c7d21e
Compare
This comment has been minimized.
This comment has been minimized.
3 tasks
8c7d21e to
d6d6fcd
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
For updating doc comments like the others, @rustbot author |
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
d6d6fcd to
dbb711e
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
These symbols are troublesome. They can change upstream. They don't work well with SemVer. Usage advice is needed. This patch links to it.
c157d77 to
b7670b6
Compare
*LAST constants fitting #3131*LAST constants
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds documentation. Some symbols are troublesome. They can change upstream. The Rust change is non-breaking. This requires annotating. It requires usage advice. This patch links to it.
Notes
QNX is untouched. Sources were not found. Their SDK sign up is broken.
Solaris is mostly untouched. Sources were not found. Changes include generic symbols. These were sourced from Illumos.
Sources
FreeBSD manpage detailing how
UTXDB_LASTLOGINis not the type of constant we would want to deprecate.DragonFlyBSD sources showing how they define a
UTX_DB_LASTLOGXsymbol but not aUTX_DB_LASTLOGsymbol as we do.Android sources showing how they use the
NF_*_PRI_LASTin much the same manner as the Linux sources (further below.)Linux sources showing the use of
NF_*_PRI_LASTconstants as trailing enumeration constants defined in terms of large values.Illumos sources showing how
_PC_LASTshould be changed when adding new_PCconstants.OpenBSD sources showing how
_LC_LASTserves as the "end" value for constants defined prior to it.Checklist
libc-test/semverhave been updated*LASTor*MAXare included (see #3131)cd libc-test && cargo test --target mytarget); especially relevant for platforms that may not be checked in CI@rustbot label +stable-nominated