Skip to content

crate: annotate unstalbe *LAST constants#5120

Open
dybucc wants to merge 1 commit into
rust-lang:mainfrom
dybucc:_last-deprecation
Open

crate: annotate unstalbe *LAST constants#5120
dybucc wants to merge 1 commit into
rust-lang:mainfrom
dybucc:_last-deprecation

Conversation

@dybucc

@dybucc dybucc commented May 28, 2026

Copy link
Copy Markdown
Contributor

Description

This PR adds documentation. Some symbols are troublesome. They can change upstream. The Rust change is non-breaking. This requires annotating. It requires usage advice. This patch links to it.

Notes

QNX is untouched. Sources were not found. Their SDK sign up is broken.

Solaris is mostly untouched. Sources were not found. Changes include generic symbols. These were sourced from Illumos.

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget); especially relevant for platforms that may not be checked in CI

@rustbot label +stable-nominated

@rustbot

rustbot commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in a NetBSD-like module

cc @semarie

Some changes occurred in an OpenBSD module

cc @semarie

Some changes occurred in a solarish module

cc @jclulow, @pfmooney

Some changes occurred in an Android module

cc @maurer

@rustbot

This comment has been minimized.

@dybucc dybucc force-pushed the _last-deprecation branch from 655cbe6 to 55dce9c Compare May 28, 2026 10:41
@rustbot

This comment has been minimized.

@dybucc dybucc force-pushed the _last-deprecation branch 2 times, most recently from 6d89662 to ff01f04 Compare May 28, 2026 10:44
@rustbot

This comment has been minimized.

@dybucc dybucc force-pushed the _last-deprecation branch 3 times, most recently from 05d5fe8 to bd2bb5b Compare May 28, 2026 12:04
@dybucc dybucc changed the title refactor deprecate *LAST constants fitting #3131 refactor deprecate *LAST constants fitting #3131 May 30, 2026
@dybucc dybucc force-pushed the _last-deprecation branch 2 times, most recently from bf8abd7 to b1ea172 Compare June 4, 2026 07:08
@rustbot

This comment has been minimized.

dybucc added a commit to dybucc/libc that referenced this pull request Jun 8, 2026
This patch is a follow up to rust-lang#5120. That PR deprecated the now removed
symbols such that it could be included in a stable release. This patch
targets the 1.0 release, by altogether removinga the symbols and
updating the SemVer-tracking file.

See the accompanying PR for more details.
dybucc added a commit to dybucc/libc that referenced this pull request Jun 9, 2026
This patch is a follow up to rust-lang#5120. That PR deprecated the now removed
symbols such that it could be included in a stable release. This patch
targets the 1.0 release, by altogether removinga the symbols and
updating the SemVer-tracking file.

See the accompanying PR for more details.
@dybucc dybucc force-pushed the _last-deprecation branch from b1ea172 to 8e5ad96 Compare June 9, 2026 07:12
@rustbot

This comment has been minimized.

@dybucc

dybucc commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

CI actually passes. There seems to be an issue with a glob import that is not used, but this has not
been changed in the patch (it's not even part of it, for that matter.) For some reason, rebasing
onto main with dependabot updates has ended up with a warning across all of my open PRs due to
that one (now apparently unused) import.

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Jun 9, 2026
dybucc added a commit to dybucc/libc that referenced this pull request Jun 15, 2026
This patch is a follow up to rust-lang#5120. That PR deprecated the now removed
symbols such that it could be included in a stable release. This patch
targets the 1.0 release, by altogether removinga the symbols and
updating the SemVer-tracking file.

See the accompanying PR for more details.
@dybucc dybucc force-pushed the _last-deprecation branch from 8e5ad96 to 8c7d21e Compare June 15, 2026 15:26
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@tgross35

Copy link
Copy Markdown
Contributor

For updating doc comments like the others, @rustbot author

@rustbot

rustbot commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@dybucc dybucc force-pushed the _last-deprecation branch from d6d6fcd to dbb711e Compare June 23, 2026 07:32
@rustbot

rustbot commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

These symbols are troublesome. They can change upstream. They don't work
well with SemVer. Usage advice is needed. This patch links to it.
@dybucc dybucc force-pushed the _last-deprecation branch from c157d77 to b7670b6 Compare June 23, 2026 07:36
@dybucc dybucc changed the title refactor deprecate *LAST constants fitting #3131 crate: annotate unstalbe *LAST constants Jun 23, 2026
@dybucc

dybucc commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@tgross35 The PR is updated. The description has changed. It should be clearer now.

@rustbot ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants