feat: add macro to declare unstable constants#5180
Closed
dybucc wants to merge 1 commit into
Closed
Conversation
This patch adds a new macro that can be used for declaring constants when these are known to possibly change upstream across target OS/ABI versions.
rustbot
added
the
stable-nominated
Contributor
Author
|
Closing in favor of having a simpler doc comment. |
tgross35
removed
the
stable-nominated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new macro that should align with the new usage guidelines in #5179.
This macro is meant to be used with constants that are likely to suffer from SemVer-breaking changes but which the new usage guidelines accept as being part of stable
libccrate relases.It has been used in #5118, #5119, #5120, #5121, #5122 and #5123.
While that PR gets merged, this PR will be left as a draft. The reason for that is that the link to the usage guidelines may change until #5179 is complete.
Sources
Does not qualify.
Checklist
libc-test/semverhave been updated*LASTor*MAXare included (see #3131)cd libc-test && cargo test --target mytarget); especially relevant for platforms that may not be checked in CI@rustbot label +stable-nominated