Repository navigation
fix(usage): correct 90-day retention and prune while idle - #45
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review Please review the latest head, including the final existing-file-only |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Context
Follow-up to the two unresolved P2 review threads on #44:
Changes
read_summary(days=90): the current UTC date plus the prior 89 dates, excluding the date exactly 90 days prior.ThreadingHTTPServer.serve_forever()'s existingservice_actions()lifecycle to prune on startup and hourly without traffic; no new service, worker, timer or scheduler. SQLite maintenance uses a zero busy timeout and cannot break user requests.--prune-expired --db PATHfor operator cleanup after opt-out or shutdown, without creating a missing database. Turn on SQLitesecure_deletefor deletions.Verification
c39e4e1: workflow run 39082220343. Python 3.10: 369 tests, OK (2 skipped); Python 3.11: 369 tests, OK (1 skipped).26333d39b992458475feb7940292aa9f89f5a7ba.X_READER_USAGE_DB, change a service drop-in, deploy, or merge.Residual operating limit
On a stopped service, or after telemetry is disabled, no in-process work can run. Strict deletion while offline requires an already-governed external maintenance guarantee or explicit operator cleanup; do not claim a hard 90-day maximum from this PR alone.