Skip to content

ci: promote PHPCS from advisory to gating #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rpgmem merged 1 commit into from
Apr 16, 2026
Merged

ci: promote PHPCS from advisory to gating #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/phpcs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,9 @@ jobs:
changed:
name: WPCS on changed PHP files
runs-on: ubuntu-latest
# Advisory only: 84k+ pre-existing violations need a dedicated cleanup
# sprint before this can gate merges. Surfaces issues on new/touched
# code without blocking.
continue-on-error: true
# Promoted to gating after cleanup sprints #25-#27 reduced violations
# from 88k to ~1.3k. Remaining violations only surface when a PR
# touches a file that still has legacy issues.
steps:
- uses: actions/checkout@v6
with:
Expand Down Expand Up @@ -62,4 +61,4 @@ jobs:
- name: Run PHPCS on changed files
if: steps.changed.outputs.files != ''
run: |
vendor/bin/phpcs -q --report=checkstyle ${{ steps.changed.outputs.files }} | cs2pr || true
vendor/bin/phpcs -q --report=checkstyle ${{ steps.changed.outputs.files }} | cs2pr
10 changes: 5 additions & 5 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,14 @@ Run these before opening a PR — CI runs the same commands.
vendor/bin/phpstan analyze # static analysis
vendor/bin/phpunit # unit tests
composer audit --locked # security advisories
vendor/bin/phpcs # WordPress Coding Standards (advisory)
vendor/bin/phpcs # WordPress Coding Standards (gating)
vendor/bin/phpcbf # auto-fix many WPCS violations
```

PHPCS runs in CI on changed PHP files only and is currently advisory:
the legacy codebase has thousands of pre-existing violations. New code
should be WPCS-clean; a dedicated cleanup sprint will promote PHPCS to
gating once the baseline shrinks.
PHPCS runs in CI on changed PHP files and **gates merges**. If your PR
touches a file with pre-existing violations, you must fix them (or run
`vendor/bin/phpcbf` to auto-fix most). Run `vendor/bin/phpcs <file>`
locally before pushing to catch issues early.

If you edit anything under `assets/css/` or `assets/js/`, rebuild the
minified bundles:
Expand Down
Loading