ci: promote PHPCS from advisory to gating - #28
Merged
Conversation
Cleanup sprints #25-#27 reduced PHPCS violations from 88,399 to ~1,295. The remaining violations are in untouched legacy files (mostly missing docblocks) and only surface when a PR touches those files. - Removed continue-on-error: true from PHPCS job - Removed || true from phpcs command so non-zero exit fails the check - Updated CONTRIBUTING.md to reflect gating status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Cleanup sprints #25-#27 reduced PHPCS violations from 88,399 to ~1,295. The check can now gate merges without blocking legitimate work.
What changed
continue-on-error: truefrom PHPCS job|| truefrom phpcs command — non-zero exit now fails the checkHow it works
PHPCS only scans PHP files changed in the PR. If a PR touches a file with pre-existing violations (~1,295 remain in legacy files, mostly missing docblocks), those violations block the merge. This incentivizes gradual cleanup as files are touched.
After merge — user action
Add
WPCS on changed PHP filesas a required check in Settings → Rules (same ruleset where you added PHPUnit 8.1-8.4).Test plan