Remove fzf interactive selection for ros2 service call (backport #1244)#1246
Open
mergify[bot] wants to merge 1 commit into
Open
Remove fzf interactive selection for ros2 service call (backport #1244)#1246mergify[bot] wants to merge 1 commit into
ros2 service call (backport #1244)#1246mergify[bot] wants to merge 1 commit into
Conversation
Signed-off-by: Tony Najjar <tony.najjar@dexory.com> (cherry picked from commit 55f7f02)
fujitatomoya
approved these changes
Jun 19, 2026
Collaborator
|
Pulls: #1246 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After upgrading to Lyrical, I found out that the feature introduced here is not working as expected for
ros2service.When running
ros2 service call <service-name>, fzf pulls out a list of service names although we already specified it:Also plain
ros2 service callwithout a service name does not trigger the fzf list of service names:Aside for the bug, I currently can't see a nice UX for
ros2 service callwith fzf because currently the command is executed directly after the fzf selection but forros2 service callmore often than not, the user wants to specify the values in the request which is currently not possible. This ties with #1184For this reason I propose we remove this functionality that does not work until we can find a clean fix and UX
Fixes # (issue)
Is this user-facing behavior change?
Did you use Generative AI?
Additional Information
This is an automatic backport of pull request #1244 done by [Mergify](https://mergify.com).